add httpx to optional deps and only ship tests in sdist #1633
+16
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xavdid-stripe
requested review from
helenye-stripe and
jar-stripe
and removed request for
a team
jar-stripe
approved these changes
Oct 3, 2025
|
build seems to be failing |
|
pesky toml tables! should be clear now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
This is two small changes in 1 PR:
teststo oursdist#1627 that haven't shipped yet to ship only what people needpip install stripe[async]and they'll get everything they need for async requests.What?
pyproject.tomltestsfrom our sdistSee Also
Changelog
asyncoptional dependency. Now,pip install stripe[async]gets you everything you need to make async HTTP calls out of the box.