Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow failures on Pypy3 #528

Merged
merged 1 commit into from
Jan 26, 2019
Merged

Conversation

brandur
Copy link
Contributor

@brandur brandur commented Jan 25, 2019

Pypy3's been breaking pretty regularly due to an import error:

ImportError: cannot import name 'pythonapi'
make: *** [init] Error 1

Here we (temporarily) allow it to fail in the build matrix so that we
can get the general build back to green.

r? @ob-stripe This is obviously not great, but a failing master build
isn't either :) What do you think about bringing this in temporarily and
trying to get the Pypy3 build fixed later? It's not too obvious to me
why it's failing -- I'd have to spend some time digging in.

@ob-stripe
Copy link
Contributor

Yeah, it's annoying. I fixed the pipenv issue with PyPy 3 a while back (pypa/pipenv#3322), but they haven't released any new version since then.

Mind adding a comment to explain this is just a pipenv/PyPy3 compatibility issue? Feel free to merge afterwards.

Pypy3's been breaking pretty regularly due to an import error:

    ImportError: cannot import name 'pythonapi'
    make: *** [init] Error 1

Here we (temporarily) allow it to fail in the build matrix so that we
can get the general build back to green.
@brandur-stripe
Copy link
Contributor

Oh, right! Now that you mention it, I remember you talking about that. That is annoying :)

I added a comment explaining that it should be possible to remove Pypy3 from allow_failures soon with a link to your PR. Thanks!

@brandur-stripe brandur-stripe merged commit 8094611 into master Jan 26, 2019
@brandur-stripe brandur-stripe deleted the brandur-allow-failure-pypy3 branch January 26, 2019 00:08
@jleclanche
Copy link
Contributor

jleclanche commented Jan 26, 2019

@brandur-stripe @ob-stripe A bit crass but you could apply the patch after pipenv is installed but before it's run on Travis. This would allow the build to run at least (and who knows if there's other issues in pipenv with pypy)

@brandur-stripe
Copy link
Contributor

@jleclanche Great point! My general feeling is that it's probably not worth it right now in that if we just wait a bit longer for a release we can save ~an hour's worth of work and spend it elsewhere. Let's revisit that if the release turns out to be a really long time coming though — I'm not opposed to giving the idea a shot at that point.

@ob-stripe
Copy link
Contributor

Alternatively, we could pin pipenv to a previous version since the PyPy3 incompatibility was introduced in a recent release.

@brandur-stripe
Copy link
Contributor

@ob-stripe Yep. Up to you on that one! Might be worth it if you know you can do it quickly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants