Skip to content

Fix Gradle Plugin version #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Fix Gradle Plugin version #18

wants to merge 2 commits into from

Conversation

loay
Copy link
Contributor

@loay loay commented Jan 29, 2016

@loay loay added the #review label Jan 29, 2016
@loay loay force-pushed the issue760 branch 4 times, most recently from f3c11cc to 253ef7a Compare February 2, 2016 02:47
@loay
Copy link
Contributor Author

loay commented Feb 2, 2016

@bajtos
Tests are passing now.

@@ -3,7 +3,7 @@ buildscript {
mavenCentral()
}
dependencies {
classpath 'com.android.tools.build:gradle:2.10.0'
classpath 'com.android.tools.build:gradle:1.5.+'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be nice if we could eventually upgrade to gradle 2.x, but let's leave that for another day.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gradle is updated to 2.10
That's the Android plugin for Gradle. The most recent version is 1.5
I got confused with that before till I got an error in the build.

@bajtos
Copy link
Contributor

bajtos commented Feb 2, 2016

One comment to address, then you can land this PR without waiting for another review. Thank you!

@bajtos bajtos assigned loay and unassigned bajtos Feb 2, 2016
Fix CI Errors
Conflicts:
	LoopbackGuideApplication/build.gradle
	LoopbackGuideSkeleton/build.gradle
@loay loay closed this Feb 2, 2016
@loay loay removed the #review label Feb 2, 2016
@loay loay deleted the issue760 branch February 2, 2016 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants