[SEMVER-MAJOR] Switch from Bluebird to native Promise #1631
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a breaking change. Juggler methods are no longer returning instances of Bluebird Promise, but return a native Promise instead. As a result, API consumers can no longer use sugar APIs provided by Bluebird, e.g. `spread`, `delay`, etc. Migration guide: rewrite your code from `.then()` style into `async` functions using `await` statements.
bajtos
requested review from
b-admike,
dhmlau,
jannyHou,
virkt25 and
zbarbuto
as code owners
This was referenced Jun 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we want to start writing
asyncfunctions usingawaitstatements then we must remove Bluebird from our public API. This pull request is doing exactly that.This is a breaking change. Juggler methods are no longer returning instances of Bluebird Promise, but return a native Promise instead.
As a result, API consumers can no longer use sugar APIs provided by Bluebird, e.g.
spread,delay, etc.Migration guide: rewrite your code from
.then()style intoasyncfunctions usingawaitstatements.