Skip to content

chore: add contributing section to readme #1858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 6, 2020
Merged

chore: add contributing section to readme #1858

merged 1 commit into from
Aug 6, 2020

Conversation

dhmlau
Copy link
Member

@dhmlau dhmlau commented Aug 5, 2020

Add the Contributing section to README using https://github.com/strongloop/loopback.io#contributing as the reference.

Signed-off-by: Diana Lau dhmlau@ca.ibm.com

Checklist

👉 Read and sign the CLA (Contributor License Agreement) 👈

  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • Commit messages are following our guidelines

@dhmlau
chore: add contributing section to readme
c94214b 
Signed-off-by: Diana Lau <dhmlau@ca.ibm.com>
@dhmlau
Copy link
Member Author

dhmlau commented Aug 5, 2020

@slnode test please

@dhmlau dhmlau self-assigned this Aug 6, 2020
@dhmlau dhmlau merged commit 35e032d into master Aug 6, 2020
jannyHou added a commit that referenced this pull request Sep 25, 2020
@jannyHou
4.20.1
8031e54 
 * chore: add test for atomic upsertWithWhere (#1864) (Matteo Padovano)
 * chore: update PR template (#1863) (Diana Lau)
 * update PR template to include DCO (#1859) (Diana Lau)
 * chore: add contributing section to readme (#1858) (Diana Lau)
@rmg rmg deleted the contributing branch March 18, 2021 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raymondfeng raymondfeng raymondfeng approved these changes

@emonddr emonddr Awaiting requested review from emonddr

@jannyHou jannyHou Awaiting requested review from jannyHou

@zbarbuto zbarbuto Awaiting requested review from zbarbuto

+1 more reviewer

@agnes512 agnes512 agnes512 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@dhmlau dhmlau

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dhmlau @raymondfeng @agnes512