Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
deploying a loopback 4 application to kubernetes on the IBM Cloud #2160
Hi @dremond71, thank you for the pull request.
Please sign our CLA here:
Next, make sure
The commit message is not following our guidelines, but that can be fixed at the end.
bajtos left a comment
Awesome content. I am not familiar with Kubernetes myself, but the guide is so detailed that I am pretty confident I'll be able to deploy LB4 to Kubernetes now.
I wish the process could be more automated and required less steps, but that's out of scope of this pull request.
I am trying to build the HTML, to test out some includes,
as mentioned in https://loopback.io/doc/en/contrib/alerts.html#types-of-alerts
in my MD file,
I am running ./bin/build-docs-site.sh
and I cannot get past this:
Any help is appreciated.
I am on Mac OSX
@bajtos , after generating the HTML, when I view my file
I do not see the images I have placed in my MD file:
Is this normal?
./bin/build_docs_site.sh works to completion on my machine without error.
But : npm run test
I am not sure if the generated HTML files can be viewed directly. I was always starting Jekyll in an interactive & incremental mode and accessing the website via HTTP.
IIRC, the first step is to run
This looks like a problem in the way how Ruby is set on your system. I am using Homebrew for installing global dev tools including Ruby, it sets the filesystem permissions on such way that no root access (
added a commit
this pull request
Jan 7, 2019
The Jekyll generated HTML should be viewable directly since Jekyll is meant to produce static sites that can be hosted on any static http server. That's why there are so many restrictions on how content is organized. That said, the workarounds for those limitations might introduce browser JS that trips over CORS and related issues when trying to render a local file.
Reminder for myself:
Then I build the documentation from the main directory
This creates content in the directory:
My generated HTML file is:
Loading this file in a browser, as-is, the images don't resolve since the image urls are now:
and located in
To view my HTML document with the images, I must go into the directory
This loads the HTML in a local server instance, and now my document shows the images as properly resolved.
@emonddr use the standard Markdown image tag for including images in all LB4 docs.
-- from PR #2226
bajtos left a comment
LGTM as far as I am concerned. Please work with @raymondfeng to address his unresolved comments too.
Once done, please clean up the git history - squash all commits into a single one, make sure the commit message is following our Commit message guidelines and rebase the change on top of the latest master via
I am looking forward to see this great guide online in our docs!