New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deploying a loopback 4 application to kubernetes on the IBM Cloud #2160

Merged
merged 1 commit into from Jan 24, 2019

Conversation

Projects
None yet
8 participants
@dremond71
Copy link

dremond71 commented Dec 14, 2018

Checklist

  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Documentation in /docs/site was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in examples/* were updated

@dremond71 dremond71 requested review from bajtos and raymondfeng as code owners Dec 14, 2018

@dremond71

This comment has been minimized.

Copy link
Author

dremond71 commented Dec 14, 2018

originated from : #1606

@bajtos

This comment has been minimized.

Copy link
Member

bajtos commented Dec 14, 2018

Hi @dremond71, thank you for the pull request.

Please sign our CLA here:
https://cla.strongloop.com/agreements/strongloop/loopback-next

Next, make sure npm test is passing locally for you. You can run npm run lint:fix to fix formatting errors.

The commit message is not following our guidelines, but that can be fixed at the end.

@bajtos
Copy link
Member

bajtos left a comment

Awesome content. I am not familiar with Kubernetes myself, but the guide is so detailed that I am pretty confident I'll be able to deploy LB4 to Kubernetes now.

I wish the process could be more automated and required less steps, but that's out of scope of this pull request.

Great work! ❤️

Show resolved Hide resolved docs/site/Deploying_to_ibm_cloud_kubernetes.md Outdated
Show resolved Hide resolved docs/site/Deploying_to_ibm_cloud_kubernetes.md Outdated
Show resolved Hide resolved docs/site/Deploying_to_ibm_cloud_kubernetes.md Outdated
Show resolved Hide resolved docs/site/Deploying_to_ibm_cloud_kubernetes.md Outdated
Show resolved Hide resolved docs/site/Deploying_to_ibm_cloud_kubernetes.md Outdated
# References
[Getting started with the IBM Cloud CLI](https://cloud.ibm.com/docs/cli/index.html#overview)

This comment has been minimized.

@bajtos

bajtos Dec 14, 2018

Member

Please reformat this section as a list of bullet points, e.g.

- [Getting started with the IBM Cloud CLI](...url...) will help you to install all the CLIs you will need
- [Kubernetes CLI (kubectl)](...url...)
- etc.

This comment has been minimized.

@emonddr

emonddr Dec 16, 2018

Contributor

done

This comment has been minimized.

@bajtos

bajtos Jan 7, 2019

Member

done

I see the old version here (no list of bullet points), could you @emonddr please check?


## Step 1: Scaffold LoopBack 4 app

Run ````lb4 app```` command.

This comment has been minimized.

@raymondfeng

raymondfeng Dec 14, 2018

Member

Not sure why ```` is used.

This comment has been minimized.

@emonddr

emonddr Dec 16, 2018

Contributor

fixed. thx.


Run ````lb4 app```` command.

````

This comment has been minimized.

@raymondfeng

raymondfeng Dec 14, 2018

Member

It should be ```.

This comment has been minimized.

@emonddr

emonddr Dec 16, 2018

Contributor

done


It is important for the host to be ````'0.0.0.0'```` and the port to be consistent in several places. We will use a port of ````8080````.

````

This comment has been minimized.

@raymondfeng

raymondfeng Dec 14, 2018

Member

Use ```ts

This comment has been minimized.

@emonddr

emonddr Dec 16, 2018

Contributor

done

@raymondfeng

This comment has been minimized.

Copy link
Member

raymondfeng commented Dec 14, 2018

@dremond71 Thank you for the PR. Please run npm lint:fix to resolve the formatting issue.

if (!options.rest) options.rest = {};
options.rest.port = 8080;
options.rest.host = "0.0.0.0";
// ----------------------------------------

This comment has been minimized.

@raymondfeng

raymondfeng Dec 14, 2018

Member

We have configured options in index.js as part of step 2. Is step 3 still needed?

This comment has been minimized.

@emonddr

emonddr Dec 16, 2018

Contributor

not sure. It worked when I edited both. I will try next week.

This comment has been minimized.

@JesusTheHun

JesusTheHun Jan 8, 2019

did you find time to try ?

This comment has been minimized.

@emonddr

emonddr Jan 23, 2019

Contributor

I've finally had the chance to experiment with this a bit more. It turns out @raymondfeng is correct. "Modify deploy-test/src/index.ts" is not needed if I have done "Modify deploy-test/index.js".

This comment has been minimized.

@emonddr
````

Make sure there are no errors before continuing to the next step.

This comment has been minimized.

@raymondfeng

raymondfeng Dec 14, 2018

Member

Why do you want remove prestart and manually run npm run build before npm start?

This comment has been minimized.

@emonddr

emonddr Dec 16, 2018

Contributor

This was a step suggested in

https://medium.com/loopback/deploy-your-first-loopback4-application-to-ibm-cloud-2e671ac06b6c

published by @dhmlau .

I figured there was a good reason to do this, so I copied the instruction.

This comment has been minimized.

@emonddr

emonddr Jan 23, 2019

Contributor

@raymondfeng , I just spoke with @b-admike , and he suggested I don't need to remove this from the package.json for the purposes of this how-to article. But it may be something the user would do to save time publish to production level.

```
lb4-simple-web-app latest 7d26df6c1561
```

This comment has been minimized.

@raymondfeng

raymondfeng Dec 14, 2018

Member

The docker related files can be added as part of lb4 app if we add such feature, for example, lb4 app my-app --docker. Consider to submit another PR for that.

@raymondfeng

This comment has been minimized.

Copy link
Member

raymondfeng commented Dec 14, 2018

@dremond71 Great tutorial! I look forward to automating some of the key steps into @loopback/cli.

@hacksparrow ^^^

@dhmlau

This comment has been minimized.

Copy link
Contributor

dhmlau commented Dec 14, 2018

@dremond71, got some info from @rmg on CLA. Looks like the PR is created by dremond71 but the commits are by emonddr - the CLA has to be signed by the commit authors, not the PR author.

@emonddr

This comment has been minimized.

Copy link
Contributor

emonddr commented Dec 15, 2018

I want to thank everyone for the positive comments :)
I will fix the issues you have mentioned...

@emonddr

This comment has been minimized.

Copy link
Contributor

emonddr commented Dec 15, 2018

I am trying to build the HTML, to test out some includes,

as mentioned in https://loopback.io/doc/en/contrib/alerts.html#types-of-alerts

in my MD file,

Deploying_to_ibm_cloud_kubernetes.md

I am running ./bin/build-docs-site.sh

and I cannot get past this:


lerna success Bootstrapped 1 package
Fetching gem metadata from https://rubygems.org/.........
Following files may not be writable, so sudo is needed:
  /Library/Ruby/Gems/2.3.0
  /Library/Ruby/Gems/2.3.0/build_info
  /Library/Ruby/Gems/2.3.0/cache
  /Library/Ruby/Gems/2.3.0/doc
  /Library/Ruby/Gems/2.3.0/extensions
  /Library/Ruby/Gems/2.3.0/gems
  /Library/Ruby/Gems/2.3.0/specifications
Fetching concurrent-ruby 1.1.3


Your user account isn't allowed to install to the system RubyGems.
  You can cancel this installation and run:

      bundle install --path vendor/bundle

  to install the gems into ./vendor/bundle/, or you can enter your password
  and install the bundled gems to RubyGems using sudo.

  Password:

Any help is appreciated.

I am on Mac OSX

@emonddr

This comment has been minimized.

Copy link
Contributor

emonddr commented Dec 16, 2018

Running with sudo seems to have gotten it farther...

sudo ./bin/build-docs-site.sh

@emonddr

This comment has been minimized.

Copy link
Contributor

emonddr commented Dec 16, 2018

@bajtos , after generating the HTML, when I view my file

file:///Users/dremond/git/loopback-next/sandbox/loopback.io/_site/doc/en/lb4/deploying_to_ibm_cloud_kubernetes.html

I do not see the images I have placed in my MD file:

/Users/dremond/git/loopback-next/docs/site/Deploying_to_ibm_cloud_kubernetes.md

Is this normal?

Please advise.

Thanks

@emonddr

This comment has been minimized.

Copy link
Contributor

emonddr commented Dec 16, 2018

./bin/build_docs_site.sh works to completion on my machine without error.

But : npm run test

eventually fails:

> loopback-next@0.1.0 test /Users/dremond/git/loopback-next
> node packages/build/bin/run-nyc npm run mocha --scripts-prepend-node-path


> loopback-next@0.1.0 mocha /Users/dremond/git/loopback-next
> node packages/build/bin/run-mocha "packages/*/dist/test/**/*.js" "examples/*/dist/test/**/*.js" "packages/cli/test/**/*.js" "packages/build/test/*/*.js"



  ․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․
  ․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․
  ․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․
  ․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․
  ․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․
  ․․․․․․․․․․․․Cannot proxy GET http://example.com/. RequestError: Error: getaddrinfo ENOTFOUND example.com example.com:80
    at new RequestError (/Users/dremond/git/loopback-next/packages/http-caching-proxy/node_modules/request-promise-core/lib/errors.js:14:15)
    at Request.plumbing.callback (/Users/dremond/git/loopback-next/packages/http-caching-proxy/node_modules/request-promise-core/lib/plumbing.js:87:29)
    at Request.RP$callback [as _callback] (/Users/dremond/git/loopback-next/packages/http-caching-proxy/node_modules/request-promise-core/lib/plumbing.js:46:31)
    at self.callback (/Users/dremond/git/loopback-next/packages/http-caching-proxy/node_modules/request/request.js:185:22)
    at Request.emit (events.js:187:15)
    at Request.onRequestError (/Users/dremond/git/loopback-next/packages/http-caching-proxy/node_modules/request/request.js:881:8)
    at ClientRequest.emit (events.js:182:13)
    at Socket.socketErrorListener (_http_client.js:391:9)
    at Socket.emit (events.js:182:13)
    at emitErrorNT (internal/streams/destroy.js:82:8)
    at emitErrorAndCloseNT (internal/streams/destroy.js:50:3)
    at process._tickCallback (internal/process/next_tick.js:63:19)
!Cannot proxy GET https://example.com/. RequestError: Error: getaddrinfo ENOTFOUND example.com example.com:443
    at new RequestError (/Users/dremond/git/loopback-next/packages/http-caching-proxy/node_modules/request-promise-core/lib/errors.js:14:15)
    at Request.plumbing.callback (/Users/dremond/git/loopback-next/packages/http-caching-proxy/node_modules/request-promise-core/lib/plumbing.js:87:29)
    at Request.RP$callback [as _callback] (/Users/dremond/git/loopback-next/packages/http-caching-proxy/node_modules/request-promise-core/lib/plumbing.js:46:31)
    at self.callback (/Users/dremond/git/loopback-next/packages/http-caching-proxy/node_modules/request/request.js:185:22)
    at Request.emit (events.js:187:15)
    at Request.onRequestError (/Users/dremond/git/loopback-next/packages/http-caching-proxy/node_modules/request/request.js:881:8)
    at ClientRequest.emit (events.js:182:13)
    at TLSSocket.socketErrorListener (_http_client.js:391:9)
    at TLSSocket.emit (events.js:182:13)
    at emitErrorNT (internal/streams/destroy.js:82:8)
    at emitErrorAndCloseNT (internal/streams/destroy.js:50:3)
    at process._tickCallback (internal/process/next_tick.js:63:19)
!․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․
  ․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․
  ․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․
  ․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․
  ․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․,․,․,
  ․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․
  ․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․
  ․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․
  ․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․
  ․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․
  ․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․
  ․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․
  ․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․
  ․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․
  ․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․
  ․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․
  ․․․․․․․․․․․․․․․․․․․․․․․․․no-unused-variable is deprecated. Since TypeScript 2.9. Please use the built-in compiler checks instead.
․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․
  ․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․
  ․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․
  ․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․
  ․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․

  1928 passing (1m)
  3 pending
  2 failing

  1) HttpCachingProxy
       proxies HTTP requests:
     StatusCodeError: 502 - ""
      at new StatusCodeError (packages/http-caching-proxy/node_modules/request-promise-core/lib/errors.js:32:15)
      at Request.plumbing.callback (packages/http-caching-proxy/node_modules/request-promise-core/lib/plumbing.js:104:33)
      at Request.RP$callback [as _callback] (packages/http-caching-proxy/node_modules/request-promise-core/lib/plumbing.js:46:31)
      at Request.self.callback (packages/http-caching-proxy/node_modules/request/request.js:185:22)
      at Request.<anonymous> (packages/http-caching-proxy/node_modules/request/request.js:1161:10)
      at IncomingMessage.<anonymous> (packages/http-caching-proxy/node_modules/request/request.js:1083:12)
      at endReadableNT (_stream_readable.js:1092:12)
      at process._tickCallback (internal/process/next_tick.js:63:19)

  2) HttpCachingProxy
       proxies HTTPs requests (no tunneling):
     StatusCodeError: 502 - ""
      at new StatusCodeError (packages/http-caching-proxy/node_modules/request-promise-core/lib/errors.js:32:15)
      at Request.plumbing.callback (packages/http-caching-proxy/node_modules/request-promise-core/lib/plumbing.js:104:33)
      at Request.RP$callback [as _callback] (packages/http-caching-proxy/node_modules/request-promise-core/lib/plumbing.js:46:31)
      at Request.self.callback (packages/http-caching-proxy/node_modules/request/request.js:185:22)
      at Request.<anonymous> (packages/http-caching-proxy/node_modules/request/request.js:1161:10)
      at IncomingMessage.<anonymous> (packages/http-caching-proxy/node_modules/request/request.js:1083:12)
      at endReadableNT (_stream_readable.js:1092:12)
      at process._tickCallback (internal/process/next_tick.js:63:19)




=== ATTENTION - INVALID USAGE OF CONSOLE LOGS DETECTED ===

Cannot proxy GET http://example.com/. RequestError: Error: getaddrinfo ENOTFOUND example.com example.com:80
    at HttpCachingProxy.logError (/Users/dremond/git/loopback-next/packages/http-caching-proxy/src/http-caching-proxy.ts:73:30)
    at onerror (/Users/dremond/git/loopback-next/packages/http-caching-proxy/src/http-caching-proxy.ts:18:36)
    at process._tickCallback (internal/process/next_tick.js:68:7)


Cannot proxy GET https://example.com/. RequestError: Error: getaddrinfo ENOTFOUND example.com example.com:443
    at HttpCachingProxy.logError (/Users/dremond/git/loopback-next/packages/http-caching-proxy/src/http-caching-proxy.ts:73:30)
    at onerror (/Users/dremond/git/loopback-next/packages/http-caching-proxy/src/http-caching-proxy.ts:18:36)
    at process._tickCallback (internal/process/next_tick.js:68:7)


npm ERR! code ELIFECYCLE
npm ERR! errno 2
npm ERR! loopback-next@0.1.0 mocha: `node packages/build/bin/run-mocha "packages/*/dist/test/**/*.js" "examples/*/dist/test/**/*.js" "packages/cli/test/**/*.js" "packages/build/test/*/*.js"`
npm ERR! Exit status 2
npm ERR!
npm ERR! Failed at the loopback-next@0.1.0 mocha script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/dremond/.npm/_logs/2018-12-16T22_04_05_389Z-debug.log
npm ERR! code ELIFECYCLE
npm ERR! errno 2
npm ERR! loopback-next@0.1.0 test: `node packages/build/bin/run-nyc npm run mocha --scripts-prepend-node-path`
npm ERR! Exit status 2
npm ERR!
npm ERR! Failed at the loopback-next@0.1.0 test script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/dremond/.npm/_logs/2018-12-16T22_04_07_111Z-debug.log
@hacksparrow

This comment has been minimized.

Copy link
Member

hacksparrow commented Dec 17, 2018

Try running npm run clean && npm run clean:lerna && npm run it.

@bajtos

This comment has been minimized.

Copy link
Member

bajtos commented Jan 3, 2019

after generating the HTML, when I view my file

I am not sure if the generated HTML files can be viewed directly. I was always starting Jekyll in an interactive & incremental mode and accessing the website via HTTP.

IIRC, the first step is to run npm run build:site, then switch to sandbox/loopback.io directory and run npm start. Unfortunately this will not pick changes made in the original markdown files in docs/site, you have to copy them over to sandbox/loopback.io/pages/en/lb4 manually. I am not happy about this cumbersome process, but didn't find time to look into ways how to improve it :(

Your user account isn't allowed to install to the system RubyGems.

This looks like a problem in the way how Ruby is set on your system. I am using Homebrew for installing global dev tools including Ruby, it sets the filesystem permissions on such way that no root access (sudo) is required. YMMV.

# References
[Getting started with the IBM Cloud CLI](https://cloud.ibm.com/docs/cli/index.html#overview)

This comment has been minimized.

@bajtos

bajtos Jan 7, 2019

Member

done

I see the old version here (no list of bullet points), could you @emonddr please check?

Show resolved Hide resolved docs/site/includes/lb4_k8s_ibm_cloud_tip.html Outdated
Show resolved Hide resolved docs/site/Deploying_to_ibm_cloud_kubernetes.md Outdated
Show resolved Hide resolved docs/site/Deploying_to_ibm_cloud_kubernetes.md Outdated
Show resolved Hide resolved docs/site/Deploying_to_ibm_cloud_kubernetes.md Outdated
Show resolved Hide resolved docs/site/Deploying_to_ibm_cloud_kubernetes.md Outdated
Show resolved Hide resolved docs/site/Deploying_to_ibm_cloud_kubernetes.md Outdated
Show resolved Hide resolved docs/site/Deploying_to_ibm_cloud_kubernetes.md Outdated
Show resolved Hide resolved docs/site/Deploying_to_ibm_cloud_kubernetes.md Outdated
Show resolved Hide resolved docs/site/Deploying_to_ibm_cloud_kubernetes.md Outdated

emonddr added a commit to dremond71/loopback-next that referenced this pull request Jan 7, 2019

@rmg

This comment has been minimized.

Copy link
Member

rmg commented Jan 7, 2019

I am not sure if the generated HTML files can be viewed directly. I was always starting Jekyll in an interactive & incremental mode and accessing the website via HTTP.

The Jekyll generated HTML should be viewable directly since Jekyll is meant to produce static sites that can be hosted on any static http server. That's why there are so many restrictions on how content is organized. That said, the workarounds for those limitations might introduce browser JS that trips over CORS and related issues when trying to render a local file.

@emonddr

This comment has been minimized.

Copy link
Contributor

emonddr commented Jan 7, 2019

Reminder for myself:

I created
/loopback-next/docs/site/Deploying_to_ibm_cloud_kubernetes.md
and my images are in
/loopback-next/docs/site/imgs
and so, in my .md file, I have image links like:

image

Then I build the documentation from the main directory

/loopback-next

using

npm run build:site

This creates content in the directory:

/loopback-next/sandbox/loopback.io

My generated HTML file is:

/loopback-next/sandbox/loopback.io/_site/doc/en/lb4/deploying_to_ibm_cloud_kubernetes.html

Loading this file in a browser, as-is, the images don't resolve since the image urls are now:

image

and located in

/loopback-next/sandbox/loopback.io/_site/pages/en/lb4/imgs/lb4_k8s_ibm_cloud_container_registry_1.png

To view my HTML document with the images, I must go into the directory

/loopback-next/sandbox/loopback.io

and run

npm start

This loads the HTML in a local server instance, and now my document shows the images as properly resolved.

@hacksparrow

This comment has been minimized.

Copy link
Member

hacksparrow commented Jan 9, 2019

@emonddr use the standard Markdown image tag for including images in all LB4 docs.

The {% include image.html file="lb4/10000000.png" alt="" %} format is a legacy remnant from the time when LoopBack docs were hosted using Confluence.

I considered the possibility of replacing all the instances of {% include image.html } tag with Markdown tags, but they are way too may in older docs. Replacing them may have unforeseen side-effects, so left them alone.

-- from PR #2226

@bajtos

This comment has been minimized.

Copy link
Member

bajtos commented Jan 10, 2019

use the standard Markdown image tag for including images in all LB4 docs.

See also what our docs say on this topic here: https://loopback.io/doc/en/contrib/images.html

@bajtos

bajtos approved these changes Jan 10, 2019

Copy link
Member

bajtos left a comment

LGTM as far as I am concerned. Please work with @raymondfeng to address his unresolved comments too.

Once done, please clean up the git history - squash all commits into a single one, make sure the commit message is following our Commit message guidelines and rebase the change on top of the latest master via git rebase master.

I am looking forward to see this great guide online in our docs! 😄

emonddr added a commit to dremond71/loopback-next that referenced this pull request Jan 23, 2019

@emonddr emonddr force-pushed the dremond71:master branch 2 times, most recently from f3db9df to 48c7464 Jan 23, 2019

@emonddr

This comment has been minimized.

Copy link
Contributor

emonddr commented Jan 23, 2019

@bajtos and @raymondfeng , I have squashed all the commits into 1 commit, and rebased with master.

@emonddr emonddr force-pushed the dremond71:master branch 2 times, most recently from 48c7464 to 35cc8d2 Jan 24, 2019

docs: guide on publishing lb4 app to kubernetes
* This guide shows users the complete step by step instructions on how to publish their LoopBack 4 application to Kubernetes on IBM Cloud.

@emonddr emonddr force-pushed the dremond71:master branch from 35cc8d2 to 4d6fff0 Jan 24, 2019

@emonddr emonddr merged commit c76a8e1 into strongloop:master Jan 24, 2019

4 checks passed

clahub All contributors have signed the Contributor License Agreement.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
security/snyk - package.json (dhmlau) No new issues
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment