Replace the Cache with a ConcurrentDictionary in StructureMap 3 #513
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cool, I'll get this rolled out into a StructureMap 3.1.9 package sometime today or by Monday at the latest. Thanks for doing this. |
|
@erik-kallen This is up in StructureMap 3.1.9 this morning. Might take a bit to index. Thanks for doing this. |
|
Thank you for helping! Do you think it would be possible for you to publish a new version of structuremap-signed as well? |
|
Hate to encourage that kind of thing, but I just pushed that one up too. |
|
Thanks. I am, unfortunately, stuck with the signed version of StructureMap 3 due to dependencies :( |
|
Which is exactly why the .Net world should get rid of strong naming post haste;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested in #512, I backported the changes that seemed necessary to replace the use of the cache with a ConcurrentDictionary from StructureMap 4 to StructureMap 3.
All tests pass