Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace the Cache with a ConcurrentDictionary in StructureMap 3 #513

Merged
merged 1 commit into from Oct 17, 2016

Conversation

@erik-kallen
Copy link

@erik-kallen erik-kallen commented Oct 14, 2016

As suggested in #512, I backported the changes that seemed necessary to replace the use of the cache with a ConcurrentDictionary from StructureMap 4 to StructureMap 3.

All tests pass

@jeremydmiller
Copy link
Contributor

@jeremydmiller jeremydmiller commented Oct 14, 2016

Cool, I'll get this rolled out into a StructureMap 3.1.9 package sometime today or by Monday at the latest. Thanks for doing this.

@jeremydmiller jeremydmiller merged commit c331d44 into structuremap:3.1 Oct 17, 2016
@jeremydmiller
Copy link
Contributor

@jeremydmiller jeremydmiller commented Oct 17, 2016

@erik-kallen This is up in StructureMap 3.1.9 this morning. Might take a bit to index. Thanks for doing this.

@erik-kallen
Copy link
Author

@erik-kallen erik-kallen commented Oct 18, 2016

Thank you for helping!

Do you think it would be possible for you to publish a new version of structuremap-signed as well?

@jeremydmiller
Copy link
Contributor

@jeremydmiller jeremydmiller commented Oct 18, 2016

Hate to encourage that kind of thing, but I just pushed that one up too.

@erik-kallen
Copy link
Author

@erik-kallen erik-kallen commented Oct 18, 2016

Thanks. I am, unfortunately, stuck with the signed version of StructureMap 3 due to dependencies :(

@jeremydmiller
Copy link
Contributor

@jeremydmiller jeremydmiller commented Oct 19, 2016

Which is exactly why the .Net world should get rid of strong naming post haste;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants