Ignore single backslash when scanning literal string #296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As stated in pdf specification: Within a literal string, the backslash () is used as an escape character for various purposes, such as to include newline characters, nonprinting ASCII characters, unbalanced parentheses, or the backslash character itself in the string. The char-acter immediately following the backslash determines its precise interpretation (see Table 3.2). If the character following the backslash is not one of those shown in the table, the backslash is ignored. When opening a pdf with PdfSharpCore, it should ignore the backslash if no character with special meaning follows it. This commit removes the exception and ignores the backslash for literal strings. This can also be done when the digit after a backslash is greater than 7.
|
Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for #292 and possibly #84 (needs testing).
Both issues are related to un-escaped character sequences in literal scanning.
As stated in pdf specification:
When opening a pdf with PdfSharpCore, it should ignore the backslash if no character with special meaning follows it. This commit removes the exception and ignores the backslash for literal strings. This can also be done when the digit after a backslash is greater than 7.