Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

latent.vars in finding DA peaks #19

Closed
Yoshi-MutoLab opened this issue Sep 3, 2019 · 2 comments
Closed

latent.vars in finding DA peaks #19

Yoshi-MutoLab opened this issue Sep 3, 2019 · 2 comments

Comments

@Yoshi-MutoLab
Copy link

Dear Tim,

Thanks for developing very useful tool for scATAC analysis.
In the vignette of "Human PBMCs" and "Adult mouse brain", latent vars = 'peak_region_fragments' was used in finding the differential peaks with FindMarkers function.

da_peaks <- FindMarkers( .......
test.use = 'LR',
latent.vars = 'peak_region_fragments' )

"Motif analysis with Signac" vignette, latent vars = 'nCount_peaks' was adopted in da_peaks selections.

da_peaks <- FindMarkers(.......
test.use = 'LR',
latent.vars = 'nCount_peaks')

I am wondering there are some reasons to select "nCount_peaks" in this situation?

Best,
Yoshi

@timoast
Copy link
Collaborator

timoast commented Sep 3, 2019

Hi Yoshi, these are essentially the same thing and I will probably change the PBMC vignette in the future to avoid confusion.

The peak_region_fragments comes from the 10x Genomics cell metadata produced by running CellRanger, and nCount_peaks is computed by Seurat (the total number of fragment counts for the cell).

They are highly correlated:

> cor(pbmc$peak_region_fragments, pbmc$nCount_peaks)
[1] 0.9999125

You can use either as a latent variable when finding DA peaks

@Yoshi-MutoLab
Copy link
Author

Thank you very much !
Yoshi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants