feat: add lazy evaluation to criteria callable - Craft 3 #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jan Henckens <jan@henckens.be>
Signed-off-by: Jan Henckens <jan@henckens.be>
…po7v Apply fixes from StyleCI
Signed-off-by: Jan Henckens <jan@henckens.be> # Conflicts: # CHANGELOG.md # composer.json # src/console/controllers/scout/IndexController.php # src/models/Settings.php
…aaw4 Apply fixes from StyleCI
Signed-off-by: Jan Henckens <jan@statik.be>
Signed-off-by: Jan Henckens <jan@statik.be>
…o0rL Apply fixes from StyleCI
Signed-off-by: Jan Henckens <jan@henckens.be>
Check methods before calling
3.1.1 # -----BEGIN PGP SIGNATURE----- # # iQGzBAABCAAdFiEE8kTipvHyprdyGl56wLsWSOmqbZMFAmSCBCgACgkQwLsWSOmq # bZM67gwAmiuLJCFbTdtafsWceSlSqxOWEcVv8zsTaCfYaHrlenNo/u3IbIdEXxuD # X8OqXZO1dYEeTgSKmQTRMWlFxgAgvQl0vX6F5pAW6g5cd+tUzJ9v7fFUPWrTTELA # 7xOdtvFt2jGpeWlBv2ROr/ystSqxVDeZq2Vhl59Mg1qaVnKp0En7xlrs4+ohDoaj # l/gG5mgFRNtPHKajU7iHdgZVW814vI4VtiFmOGFUeldpTVr6PPY6YDjlcNWfRTNG # qB8N6RAKR8V01y+CXNPMA2Ci04vi1SHbO/8ayxZbnY8SRhOm/lXS/7bSdm5MPaZZ # osNJ61gRRRygxvibQMckMTnDtS1vwfhH5QjznOuK6xNhbT3YoJbg+ok2ZvNU1H60 # 07O2krcIlulTnF5G9HifigydvkCuf0O5BCvK7pknAz8fmgL034rbeNqU7QqrXi0E # SmsvgX9FN/X8LLYBJrgxExdndMXlRdbm7dG7PV/UxcF943058DvvNiDIv9A4AuiI # d4AiYocX # =IVyc # -----END PGP SIGNATURE----- # gpg: Signature made Thu Jun 8 18:39:04 2023 CEST # gpg: using RSA key F244E2A6F1F2A6B7721A5E7AC0BB1648E9AA6D93 # gpg: Good signature from "Jan Henckens <jan@henckens.be>" [ultimate]
- Add required property when creating Field (EventHandlersTest, SearchableBehaviorTest) - Mark failing test as incomplete for now (EventHandlersTest) - Set config value to test environment (ScoutUtilityTest.php:it_returns_html) - Pass Queue instance from Application instead of new instance to prevent error "Queue must be an application component." (ImportIndexTest.php:it_calls_update_on_the_engine) Refers to studioespresso#226
…DB user as expected by test config and GH Actions Refers to studioespresso#226
…red Craft CMS version; 8.0.2 Refers to studioespresso#226
Fix tests for Craft 4-version of the plugin
Update README.md
qrazi
force-pushed
the
feat_lazy_evaluation_craft3
branch
from
9650f0d
to
166de11
Compare
|
I manually added these changes to the Craft 3 branch and they are released in the latest beta version:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refers to #257