Upgrade node-fetch to >= 2.3.0 to fix semantic-release users that use styled-components

[kopax]

Environment

We are experiencing issue on travis while using semantic-release.

This happen because of a package having being fixed node-fetch@2.3.0 for semantic-release to work and styled-components having an outdated node-fetch through isomorphic-fetch.

Users that use both semantic-release and styled-components will have issues.

• Verify condition fails on v5.2.4 with "HttpError: response.headers.entries(...) is not a function or its return value is not iterable" semantic-release/github#129
• Failed step "publish" of plugin "@semantic-release/github" semantic-release/semantic-release#995

Related issues:

• Upgrade node-fetch to >= 2.3.0 to fix semantic-release users that use styled-components styled-components#2247 (comment)
• Upgrade node-fetch to >= 2.3.0 to fix semantic-release users that use styled-components #98
• Upgrade node-fetch to >= 2.3.0 to fix semantic-release users that use styled-components facebook/fbjs#325
• Upgrade node-fetch to >= 2.3.0 to fix semantic-release users that use styled-components matthew-andrews/isomorphic-fetch#179

Reproduction

https://travis-ci.org/yeutech-lab/rollup-umd-documentation/jobs/459847412

$ npm ls node-fetch
@yeutech-lab/rollup-umd-documentation@2.4.2 /home/dka/workspace/github.com/yeutech-lab/rollup-umd-documentation
├─┬ @semantic-release/github@5.2.5
│ └─┬ @octokit/rest@16.0.1
│   └── node-fetch@2.3.0 
└─┬ styled-components@4.1.1
  └─┬ css-to-react-native@2.2.2
    └─┬ fbjs@0.8.17
      └─┬ isomorphic-fetch@2.2.1
        └── node-fetch@1.7.3 

Steps to reproduce

• semantic-release: v15.12.1
• styled-components: v4.1.1

Expected Behavior

To have node-fetch@2.3.0

Actual Behavior

Styled-components bring node-fetch@1.7.3 and breaks semantic-release.

Solution

• short term: npm install node-fetch@2.3.0 --save-dev
• long term: Upgrade chain of dependencies, require help of https://github.com/matthew-andrews/isomorphic-fetch/, https://github.com/facebook/fbjs, https://github.com/styled-components/css-to-react-native/ and https://github.com/styled-components/styled-components

[jacobp100]

Looks like we need to update fbjs to 1.0.0. I won't have a tonne of time over the next few weeks, but I'll be happy to accept a PR - it should be pretty quick to fix!

[kopax]

I don't think this will solve the problem, except if they do not rely on isomorphic-fetch (which doesn't exist with node-fetch v2) or any dependencies that rely on fetch v1.

[jacobp100]

Okay. We only use fbjs for the camel-case conversion, and it looks like that just uses camelize (with some browser workarounds that we don't need). I'd be happy to replace the dependency if that fixes it?

[mxstbr]

@jacobp100 that sounds like a great plan, let's do that!

[kopax]

@jacobp100 I didn't go that far but if you are positive that the lib is just there for that, yeah that sound great let's do that.

[kopax]

I've just pushed the proposed fix by jacobp100. I also add to remove the package-lock.json file (you do not need that) and fix the test (adding "testURL": "http://localhost" to jestConfig)