General API for overriding component names

[bebraw]

This PR adds componentNameResolver and getDefaultExportForFile helpers for writing custom component name resolvers (important for styled components and such).

[bebraw]

I updated the PR so it's mergeable. Let me know if you want something more generic. We could expose the matching mechanism if you don't like the coupling.

[pvasek]

You read my mind. This seems too hard coded. I guess it would make sense to have it in ParserOptions but I have no idea how to name it.

[bebraw]

@pvasek How about resolveComponentName(exp, source) in parserOptions? Then we pass it as an optional resolveComponentName callback to computeComponentName. If it's defined, then we run it before other logic and return possible result, otherwise it falls back to default logic. That would be enough for my purposes.

[pvasek]

@bebraw That could work but I guess if that callback return null it should be ignored and name should be calculated as it is now. Is it correct? So you can "overwrite" only name you want and keep rest of the logic otherwise.

[bebraw]

Yeah, that’s the point. I guess any falsy return value should revert back to default. Should I change the PR?

…

On Wednesday, 19 September 2018, pvasek ***@***.***> wrote: @bebraw <https://github.com/bebraw> That could work but I guess if that callback return null it should be ignored and name should be calculated as it is now. Is it correct? So you can "overwrite" only name you want and keep rest of the logic otherwise. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#127 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAKMCRpQlpJFmfgZGj2iZi7fewzKIernks5ucpadgaJpZM4WsLZZ> .

[pvasek]

That would be great. Only question is which arguments should be in that callback to be able to do most of the things.

[bebraw]

@pvasek I generalized the interface. Now the styled components bit lives outside of the parser core and can be added through a small function. I also added a helper to make it convenient to implement matchers like that.