feat: added flag to return default value not only as string type #210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evless
force-pushed
the
feat/no-string-default-props
branch
2 times, most recently
from
a2e59ed to
c3b84df
Compare
|
Would all other test pass if this flag is enabled? Maybe it should really by the default behaviour. The current state seems like bug to me. What do you think? |
|
I think that the current state looks strange, but I don't know all exceptions, maybe it was made on purpose. If this flag is enabled, so 7 tests will fail. I think tests made under string type and I can fix them. http://s.csssr.ru/U7RQKLD4J/2019-09-24-18-55-09-y9zhv.jpg |
|
Could you make your changes as a fix? I mean: remove that flag and fix these tests. So your behaviour will be the default one. |
evless
force-pushed
the
feat/no-string-default-props
branch
from
c3b84df to
9628c05
Compare
|
I fixed tests and I did my behaviour is default one :) |
|
Thanks! Published as v1.15.0 on npm. |
This was referenced Sep 30, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! I added a flag to parser can return default value not only as string type. I don't know, maybe flag is overhead and I can do this case is a default?