Handle components exported in an object #253
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pvasek
reviewed
May 2, 2020
|
|
||
| it('should parse functional component component defined as const as named export', () => { | ||
| check( | ||
| 'FunctionalComponentAsConstAsNamedExport', |
There was a problem hiding this comment.
maybe it would make sense to rename this test and file it use as it doesn't use the file name anymore.
pvasek
reviewed
May 2, 2020
|
|
||
| it('should parse React.SFC component defined as const as named export', () => { | ||
| check( | ||
| 'ReactSFCAsConstAsNamedExport', |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #176
I had to change the following test cases
https://github.com/styleguidist/react-docgen-typescript/pull/253/files#diff-c4e2044ddda57c0b9b40f972fc77d27eR629
https://github.com/styleguidist/react-docgen-typescript/pull/253/files#diff-c4e2044ddda57c0b9b40f972fc77d27eR643
They were using the name of the file for the name of the component that was already a named export. Since they are named exports and aren't exported as default I think It makes more sense the way it is now.
We could count how many exports that are, but I think the code in the PR makes more sense