fix parse error for export default interface #257
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddelbondio
force-pushed
the
fix-parse-error-on-default-interface-export
branch
2 times, most recently
from
a3a5cbc to
ce1ec08
Compare
|
@ddelbondio thanks for PR, could you fix that conflict, please? |
ddelbondio
force-pushed
the
fix-parse-error-on-default-interface-export
branch
from
ce1ec08 to
6059bbf
Compare
|
@pvasek done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
export default interface Interface {}is used the parser currently fails withError: Debug Failure. False expression: Should only get Alias hereat Object.resolveAlias [as getAliasedSymbol].It probably fails for other type only exports as well when they are used as default export. The fix makes sure only actual aliases are passed to
getAliasedSymbol.