Read default prop values from inside a forwardRef #271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi. This is my first pull request for this project. I'm not that familiar with either this project or the typescript AST. The commit hooks did some formatting that was included in the commit as well that is unrelated, let me know if you want me to skip the hook and just have my changes. Please let me know if you have other comments or suggestions. |
Tigge
force-pushed
the
forwardref
branch
2 times, most recently
from
81108ac to
f4bf684
Compare
This tries to follow and look inside of forwardRef calls when reading out default values from function statements. In addition it will look at the actual source file when doing these default value lookups. Solves: styleguidist#254
|
@Tigge Hi, i think your PR is fine. Thanks for that! I know, we have some problems with these commit hooks. I am starting to think lately that they do more harm then help. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tries to follow and look inside of
forwardRefcalls when reading out default values from function statements. In addition it will look at the actual source file when doing these default value lookups.Solves: #254