Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: generate typings directly in lib instead of lib/src #1756

Merged
merged 15 commits into from
Mar 18, 2021

Conversation

elevatebart
Copy link
Collaborator

@elevatebart elevatebart commented Mar 6, 2021

in version 11.1.5 when we moved to Github Actions we added a dangerfile.ts to the tsconfig.json
This file, since it is outside the src folder, changed the reference rootFolder for typings to calculate.
This quick adjustment should fix the typings.

I also updated CI to have clearer action steps (where we can measure progress from a high level).
Cypress 3.0.2 does not seem to work well with the Linux version on the github action docker images.

@elevatebart elevatebart requested a review from sapegin March 6, 2021 04:32
tsconfig.types.json Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Mar 6, 2021

Warnings
⚠️

Changes were made to package.json, but not to package-lock.json.

If you’ve changed any dependencies (added, removed or updated any packages), please run npm install and commit changes in package-lock.json file. Make sure you’re using npm 5+.

Generated by 🚫 dangerJS against 72a8c42

@elevatebart
Copy link
Collaborator Author

@sapegin I would like your opinion on the CI changes
When you have a minute, please advise.

@elevatebart elevatebart merged commit c3cd564 into master Mar 18, 2021
@elevatebart elevatebart deleted the fix/typings branch March 18, 2021 19:45
@github-actions
Copy link

🎉 This PR is included in version 11.1.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant