Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cursor jumping while editing in codemirror #145

Merged
merged 1 commit into from
May 20, 2016
Merged

Fix cursor jumping while editing in codemirror #145

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/rsg-components/Editor/Editor.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import s from './Editor.css';

var cssRequire = require.context('codemirror/theme/', false, /^\.\/.*\.css$/);

let UPDATE_DELAY = 100;
let UPDATE_DELAY = 10;

export default class Editor extends Component {
static propTypes = {
Expand Down Expand Up @@ -40,6 +40,10 @@ export default class Editor extends Component {
cssRequire(`./${highlightTheme}.css`);
}

shouldComponentUpdate() {
return false;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the simplicity ;-)

}

handleChange(newCode) {
let { onChange } = this.props;
if (onChange) {
Expand Down