Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: Use same code style to render null value #306

Merged
merged 1 commit into from
Feb 6, 2017

Conversation

okonet
Copy link
Member

@okonet okonet commented Feb 6, 2017

Using Boolean expression as for props. Prior method was rendering false which isn't a valid React node value.

  • Add tests for methods section.

…ssion as for props.

- Prior method was redering `false` which isn't a valid React node value.
- Add tests for methods section.
@codecov-io
Copy link

codecov-io commented Feb 6, 2017

Codecov Report

Merging #306 into next will increase coverage by 0.1%.

@@            Coverage Diff            @@
##             next     #306     +/-   ##
=========================================
+ Coverage   91.68%   91.78%   +0.1%     
=========================================
  Files          70       70             
  Lines         962      962             
  Branches      188      188             
=========================================
+ Hits          882      883      +1     
+ Misses         80       79      -1
Impacted Files Coverage Δ
...omponents/ReactComponent/ReactComponentRenderer.js 90% <100%> (+10%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fef6363...1427eee. Read the comment docs.

@sapegin
Copy link
Member

sapegin commented Feb 6, 2017

Thanks! Especially for new tests! 🦄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants