Fixes server/modules/formatter tests #450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-page
approved these changes
Apr 2, 2023
ota-meshi
added a commit
that referenced
this pull request
Oct 31, 2023
* feat: Report ranges for diagnostics * update snap * update changelog * update stylelint * Fixes server/modules/formatter tests (#450) Fix copied from original PR https://github.com/stylelint/vscode-stylelint/pull/426/files#diff-f2680deb1906c0920d4e4b4f73879a32a741ed4288aabb2a218a2eef48f38211 * update snapshot * update snapshot * fix * fix: test cases --------- Co-authored-by: yosuke ota <otameshiyo23@gmail.com> Co-authored-by: Chema Balsas <jbalsas@gmail.com>
ota-meshi
added a commit
that referenced
this pull request
Nov 2, 2023
* feat: Allow disposing server, add first LSP test (#326) * feat: Allow disposing server, add first LSP test * test: close connection before finishing * refactor: use stylelint namespace for custom event * feat: Add restart server command (#339) Closes #332 * test: add code actions on save end-to-end test (#341) * test: add code actions on save end-to-end test * test:test auto-fix on save after problem actions Quick hack to hopefully stabilize tests on CI for now * feat: Warn for old Stylelint regardless of lang ID (#340) Does not warn if Stylelint was resolved globally, only locally. * test: await functions that may return promises * fix: de-nest globs used for watching config files (#356) * fix: de-nest globs used for watching config files * test: update extension tests * docs: update changelog * fix: ts error (#471) * feat: Report ranges for diagnostics (#358) * feat: Report ranges for diagnostics * update snap * update changelog * update stylelint * Fixes server/modules/formatter tests (#450) Fix copied from original PR https://github.com/stylelint/vscode-stylelint/pull/426/files#diff-f2680deb1906c0920d4e4b4f73879a32a741ed4288aabb2a218a2eef48f38211 * update snapshot * update snapshot * fix * fix: test cases --------- Co-authored-by: yosuke ota <otameshiyo23@gmail.com> Co-authored-by: Chema Balsas <jbalsas@gmail.com> --------- Co-authored-by: Adaline Valentina Simonian <adalinesimonian@gmail.com> Co-authored-by: Chema Balsas <jbalsas@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix copied from original PR
https://github.com/stylelint/vscode-stylelint/pull/426/files#diff-f2680deb1906c0920d4e4b4f73879a32a741ed4288aabb2a218a2eef48f38211
Just trying to see if we can help push feat: Report ranges for diagnostics through the finishing line
We tested the branch and it worked nicely!
Even though CI seemed green in the PR, some tests appeared to be failing locally. We just went ahead and borrowed from refactor: update deps the smallest fix we could find that made it green locally too
cc @samrose3