Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature]: Add restart server command to extension #332

Closed
1 task done
adalinesimonian opened this issue Nov 18, 2021 · 1 comment · Fixed by #339
Closed
1 task done

[Feature]: Add restart server command to extension #332

adalinesimonian opened this issue Nov 18, 2021 · 1 comment · Fixed by #339
Assignees
@adalinesimonian
Labels
good first issue is good for newcomers type: enhancement a new feature that isn't related to rules
Milestone
v1.3.0

Comments

@adalinesimonian
Copy link
Member

What problem does this feature solve?

There are inevitably times when you need to restart the language server. Currently, you can do this by reloading the window, but that is quite excessive.

How does this feature solve the problem?

Allows the language server to be restarted via a dedicated command, similar to the ESLint and TypeScript integrations.

What are some alternatives to this feature?

No response

Code of Conduct

  • I agree to follow vscode-stylelint's Code of Conduct
@adalinesimonian adalinesimonian added the type: enhancement a new feature that isn't related to rules label Nov 18, 2021
@adalinesimonian adalinesimonian added this to the v1.3.0 milestone Nov 18, 2021
@adalinesimonian adalinesimonian added status: ready to implement is ready to be worked on by someone good first issue is good for newcomers labels Nov 18, 2021
@adalinesimonian adalinesimonian self-assigned this Nov 19, 2021
adalinesimonian added a commit that referenced this issue Nov 19, 2021
@adalinesimonian
feat: Add restart server command
e1fbe4f 
Closes #332
@adalinesimonian adalinesimonian mentioned this issue Nov 19, 2021
Merged
@adalinesimonian adalinesimonian added Fix Available and removed status: ready to implement is ready to be worked on by someone labels Nov 19, 2021
adalinesimonian added a commit that referenced this issue Nov 19, 2021
@adalinesimonian
feat: Add restart server command (#339)
fd1f84a 
Closes #332
@adalinesimonian adalinesimonian linked a pull request Nov 19, 2021 that will close this issue
feat: Add restart server command #339
Merged
@adalinesimonian
Copy link
Member Author

Done in #339

@ota-meshi ota-meshi mentioned this issue Sep 20, 2022
Open
1 task
ota-meshi added a commit that referenced this issue Nov 2, 2023
@ota-meshi @adalinesimonian @jbalsas
v1.3.0 (#472)
1222726 
* feat: Allow disposing server, add first LSP test (#326)

* feat: Allow disposing server, add first LSP test

* test: close connection before finishing

* refactor: use stylelint namespace for custom event

* feat: Add restart server command (#339)

Closes #332

* test: add code actions on save end-to-end test (#341)

* test: add code actions on save end-to-end test

* test:test auto-fix on save after problem actions

Quick hack to hopefully stabilize tests on CI for now

* feat: Warn for old Stylelint regardless of lang ID (#340)

Does not warn if Stylelint was resolved globally, only locally.

* test: await functions that may return promises

* fix: de-nest globs used for watching config files (#356)

* fix: de-nest globs used for watching config files

* test: update extension tests

* docs: update changelog

* fix: ts error (#471)

* feat: Report ranges for diagnostics (#358)

* feat: Report ranges for diagnostics

* update snap

* update changelog

* update stylelint

* Fixes server/modules/formatter tests (#450)

Fix copied from original PR

https://github.com/stylelint/vscode-stylelint/pull/426/files#diff-f2680deb1906c0920d4e4b4f73879a32a741ed4288aabb2a218a2eef48f38211

* update snapshot

* update snapshot

* fix

* fix: test cases

---------

Co-authored-by: yosuke ota <otameshiyo23@gmail.com>
Co-authored-by: Chema Balsas <jbalsas@gmail.com>

---------

Co-authored-by: Adaline Valentina Simonian <adalinesimonian@gmail.com>
Co-authored-by: Chema Balsas <jbalsas@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adalinesimonian adalinesimonian

Labels
good first issue is good for newcomers type: enhancement a new feature that isn't related to rules
Projects
None yet
Milestone
v1.3.0
Development

Successfully merging a pull request may close this issue.

feat: Add restart server command stylelint/vscode-stylelint
1 participant
@adalinesimonian