Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compressibility correction for SST model #2271

Merged
merged 32 commits into from
Jul 21, 2024

Conversation

sun5k
Copy link
Contributor

@sun5k sun5k commented Apr 23, 2024

Proposed Changes

Compressibility Correction(CC) for the k-w SST model.

Two kind of CC is implemented. Both CC were based on Wilcox's book(Turbulence Modeling for CFD 3rd) and the paper of Rumsey

The k-w SST model transport equation :

*The production term is according to version or options for SST model(SU2 ver 8.0.1 has 1994m or 2003m).
image
image

image
image
image
image
image

  1. Wilcox
    image
    image
    image
    The H is the Heaviside function.
    image

  2. Sarkar
    In the Sarkar's CC, the pressure dilatation(image) is considered. The k transport equation is :
    image
    image
    image
    image

Validation Case

Validation analysis is conducted for the hypersonic flat plate. Two different wall temperature(T_w/T_free = 1.090 and T_w/T_free = 2.725) results are presented and compared with simulation results of ANSYS Fluent.

The CC of Fluent and Wilcox is almost same, but they have different coefficients(Wilcox : image / Fluent : image). So, The results show a similar behavior to the Fluent results.
image
image

PR Checklist

Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.

  • I am submitting my contribution to the develop branch.
  • My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
  • My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
  • I used the pre-commit hook to prevent dirty commits and used pre-commit run --all to format old commits.
  • I have added a test case that demonstrates my contribution, if necessary.
  • I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.

sun5k and others added 2 commits April 23, 2024 13:08
Added two compressibility correction( Wilcox and Zeman ) for the SST model.
@bigfooted
Copy link
Contributor

That would be a nice addition! Can you also add a testcase (this flat plate testcase) for each of the cases, and add the cfg + regression tests to this repository? Maybe do the regression test on one of the coarsest meshes. Best would be to have set it up with a restart file that is completely converged.

@bigfooted
Copy link
Contributor

bigfooted commented Apr 29, 2024

Regrading the results: Why do we not see the dip in skin friction coefficient for low Reynolds like we see in the paper of Rumsey? The paper shows that predicting this dip is a feature of the model, and it makes it different from the van Driest theory.

sun5k added 13 commits April 30, 2024 20:32
regression Test
Regression
t
Regression
remove hybrid/ add parallel
Wilcox_Regression
Re2
Regression test for Wilcox and Sarkar .
Sarkar
Re
@sun5k
Copy link
Contributor Author

sun5k commented May 2, 2024

That would be a nice addition! Can you also add a testcase (this flat plate testcase) for each of the cases, and add the cfg + regression tests to this repository? Maybe do the regression test on one of the coarsest meshes. Best would be to have set it up with a restart file that is completely converged.

Hi @bigfooted.

I made regression test on "parallel_regression.py". Should I make extra regression test on "hybrid_regression.py" and "serial_regression.py"?

@sun5k
Copy link
Contributor Author

sun5k commented May 2, 2024

Regrading the results: Why do we not see the dip in skin friction coefficient for low Reynolds like we see in the paper of Rumsey? The paper shows that predicting this dip is a feature of the model, and it makes it different from the van Driest theory.

I thought it depended on the grid resolution. The case of fine resolution grid(545 x 385), we can see "dip" in SU2 result(but relatively small).

image
image

From the "Coarse-Zoom" plot, The "dip" in coarse mesh(138 x 97) also appears in SU2, but it is really weak.
image
image

Common/include/option_structure.hpp Outdated Show resolved Hide resolved
Common/include/option_structure.hpp Show resolved Hide resolved
SU2_CFD/include/numerics/turbulent/turb_sources.hpp Outdated Show resolved Hide resolved
SU2_CFD/include/numerics/turbulent/turb_sources.hpp Outdated Show resolved Hide resolved
@bigfooted
Copy link
Contributor

I copy the comment in the review here as well:
Can you check the equation for the pressure dilatation that you give above? Should I compare it to eq (39) of the paper? The equation (39) in the paper is $(-a_2 P M_t^2) +(a_3 \rho \epsilon M_t^2)$ which is different from what you write above and what is in the code. I guess you use the relationship $\epsilon=\beta^{\star} \omega k$, so the above becomes:
$(-a_2 P M_t^2) +(a_3 \beta^{\star} \rho \omega k M_t^2)$

You have in the code $(-a_2 P M_t) + (a_3 \beta^{\star} \rho \omega) + k M_t^2$

sun5k and others added 6 commits May 5, 2024 18:26
Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>
Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>
Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>
Sarkar Regression
@bigfooted
Copy link
Contributor

Can you add the updated results here? Did the results improve?

@sun5k
Copy link
Contributor Author

sun5k commented May 22, 2024

Can you add the updated results here? Did the results improve?

Hi @bigfooted , I'm sorry to forgot shearing the updated result.

Here is the result fixed for the correct source term. The Cf is slightly shifted up.

image
image

This is a comparison of the previous and the fixed result.
image
image

@bigfooted
Copy link
Contributor

@pcarruscag @sun5k Anything else necessary for this PR?

sun5k and others added 8 commits June 13, 2024 10:36
Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>
Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>
Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>
Co-authored-by: Pedro Gomes <38071223+pcarruscag@users.noreply.github.com>
Break SU2 code, if either options is selected.
@pcarruscag pcarruscag merged commit 1044ccc into su2code:develop Jul 21, 2024
34 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants