Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Concorde updates #188

Merged
merged 7 commits into from
Jul 28, 2017
Merged

Concorde updates #188

merged 7 commits into from
Jul 28, 2017

Conversation

timdmacdo
Copy link
Contributor

This includes updates to Concorde geometry parameters. The propulsor wave drag handling is also changed to ignore the inlet area.

@timdmacdo timdmacdo requested a review from planes July 28, 2017 22:05
@coveralls
Copy link

Coverage Status

Coverage increased (+0.002%) to 45.188% when pulling a1eb1a0 on concorde_updates into eb3fac6 on develop.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.002%) to 45.188% when pulling 8d695cc on concorde_updates into eb3fac6 on develop.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 45.321% when pulling 20aa549 on concorde_updates into eb3fac6 on develop.

planes
planes reviewed Jul 28, 2017
View reviewed changes
regression/scripts/concorde/concorde.py Outdated
@@ -62,7 +63,7 @@ def main():
results = mission.evaluate()

# load older results
#save_results(results)
save_results(results)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Watch it there!

@planes
Copy link
Member

planes commented Jul 28, 2017

Let's pull it like a county fair tractor pull!

@planes planes closed this Jul 28, 2017
@planes planes reopened this Jul 28, 2017
@planes planes merged commit 3b5e72b into develop Jul 28, 2017
@timdmacdo timdmacdo deleted the concorde_updates branch July 28, 2017 22:39
@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 45.195% when pulling 784c93f on concorde_updates into eb3fac6 on develop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@planes planes planes left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@timdmacdo @coveralls @planes