358 fix/delete posts by post status #395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apply fixes from StyleCI
Apply fixes from StyleCI
Change if to switch
Add Module for delete term by count Fix #178
Apply fixes from StyleCI
…tfix-prefix' into 178-feature/delete-terms--by-postfix-prefix
Apply fixes from StyleCI
Apply fixes from StyleCI
Update functions names Fix #178
Apply fixes from StyleCI
Apply fixes from StyleCI
|
Development is done, Ready to review |
Repository owner
deleted a comment
Aug 12, 2018
sudar
requested changes
Aug 12, 2018
| 'days' => '5', | ||
| ); | ||
|
|
||
| $posts_deleted = $this->module->delete( $delete_options ); |
There was a problem hiding this comment.
Assert that some additional posts that don't match the condition are not deleted.
Do this for all the other test cases as well.
|
@rajanit2000 Make sure you are adding some asserts to check that posts that don't satisfy the condition are not getting deleted. Also pull the latest code from github. |
Repository owner
deleted a comment
Aug 12, 2018
|
@sudar its ready to review |
Repository owner
deleted a comment
Aug 13, 2018
rajanvijayan
commented
Aug 13, 2018
| 'post_status' => 'pending', | ||
| ) | ||
| ); | ||
|
|
||
| $delete_options = array( | ||
| 'post_status' => array( 'publish', 'draft' ), | ||
| 'limit_to' => -1, |
There was a problem hiding this comment.
Check limit_to value
Repository owner
deleted a comment
Aug 15, 2018
sudar
approved these changes
Aug 17, 2018
ghost
removed
the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked by #332