Added Audio Samples #1626
Closed
Added Audio Samples #1626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please indicate in a comment at the top of the sound files where the samples came from. |
|
Please check spacing. Indentation doesn't match the format |
rhl-bthr
requested changes
Dec 10, 2018
js/utils/synthutils.js
Outdated
| @@ -441,6 +448,8 @@ function Synth() { | |||
| {'name': 'koto', 'data': KOTO_SAMPLE}, | |||
| {'name': 'dulcimer', 'data': DULCIMER_SAMPLE}, | |||
| {'name': 'electric guitar', 'data': ELECTRICGUITAR_SAMPLE} | |||
| {'name': 'autoharp', 'data': AUTOHARP_SAMPLE } | |||
There was a problem hiding this comment.
There are missing commas here. @aryanharitsh123, did you test the changes ?
aryanharitsh123
force-pushed
the
master
branch
from
feff3ca
to
f8744ae
Compare
|
@Hrishi1999 Indentation looks fine on my system. I don't know why it gets wierd after pushing.. :( |
I highly doubt it. If that is the case, then the changes you made in |
|
Is it fine now? |
rhl-bthr
requested changes
Dec 10, 2018
| @@ -255,6 +255,8 @@ const SELECTORSTRINGS = [ | |||
| _('violin'), | |||
| _('cello'), | |||
| _('bass'), | |||
| _('mandolin'), | |||
| @@ -142,6 +146,7 @@ var SOUNDSAMPLESDEFINES = [ | |||
| "samples/slap", "samples/clang", "samples/cup", "samples/floortom", | |||
| "samples/snare", "samples/piano", "samples/acguit", "samples/banjo", | |||
| "samples/koto", "samples/gong", "samples/dulcimer", "samples/electricguitar" | |||
| "samples/autoharp","samples/mandolin", | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.