Resolves #3849 #3850
Resolves #3849 #3850
Conversation
|
Did you test when trying to drag a block from the collapse button? What action takes precedent? collapse or drag or both (or neither)? |
I looked at it.If I drag the block anywhere except the collapse button it moves properly. But if I use the collapse button to move blocks(I click in the area of collapse button to drag blocks) , it collapses as well. Also, the initial issue of erratic functioning of collapse button is gone. So, ideally if I click on the collapse button and use it to drag around the block should it collapse and drag it? Because a click was also recorded |
|
Ideally, clicking on a block to move it would take precedence over collapse/expand. @pikurasa what do you think? |
The issue is that the "move" detecting eventlistener "pressmove" is extremely sensitive and sometimes normal clicks are also recorded as "move" actions. |
|
@walterbender @pikurasa any updates on this? |
|
Was waiting to hear back from @pikurasa |
|
In terms of dragging from the collapse area of the block, I agree with @walterbender that dragging should take precedent. So, if you drag from that area, it should just drag; not drag and expand/collapse. As for:
You may have a point here, because I often see kids "shake" the blocks when they are just trying to click on the block to trigger an event. I don't know exactly what the "sweet spot" would be for this. It probably differs between touch devices vs. using a mouse. |
There was a problem hiding this comment.
@pikurasa have a look. For the "pressmove" event listener in block.js I have calculated displacement of the element and if it's less than a certain threshold(2) , I have ignored it as a drag action and considered it as a collapse action(using the "moved" variable)
|
@pikurasa would be great to see how some of the kids at MAP do with this setting. They'd be able to "tell" us if the threshold needs adjustment. |
|
@walterbender @pikurasa What is the future scope of this PR? Is there any plan on finding out an optimum threshold as suggested by @walterbender? |
|
Devin will try to do some testing. |
|
@divyanash911 I can test with some kids. This week is an off week for public schools in the US, so I may only be able to do tests with my (six-year-old) son. I guess the one question I have is: Have you considered both laptop and mobile for this PR? Or is it just mobile? I ask because if it's just mobile, I'll focus my testing there. If both are taken into account, I can test both. |
The code changes majorly work for laptop bugs only I believe since the changes are in an if condition supported for laptops. I am unsure about shaky touches in mobile but will look into that as well. |
|
@walterbender @pikurasa Any updates? |
|
I have been working on the mobile touch thing as well but I dont find a lot of shake....are there any inputs on that? |
I can test this week. I thought my son could help test, but it seems he has gotten rather used to using a track pad (and wasn't using the screen much). |
Oh okay! Do let me know on your insights after testing! |
Testing this particular test, especially with a student cohort, has been harder than I was hoping, but "I'm working on it." In the meantime, I'll be trying some A/B tests myself and getting Kai involved a little more. |
Oh okay. I am currently busy with my final exams so I will also be unable to respond for the next few days! |
|
This pull request has been open for more than 60 days without any activity. It will be closed in 3 days unless the |
|
Closed pull request due to inactivity for more than 63 days. |
The moved variable seemed ambiguous. The erratic condition fell out of the if-else block since moved variable was creating a problem to ensure blocks collapsing.