Skip to content
This repository has been archived by the owner on Mar 14, 2022. It is now read-only.

Refactor circle ci config #448

Merged

Conversation

linuxswords
Copy link
Contributor

Hi guys

I reading into circle-ci configuration and stumbled upon the yaml anchor syntax. I feel like it would simplify a big config if used wisely :)

See https://discuss.circleci.com/t/using-defaults-syntax-in-config-yaml-aka-yaml-anchors/16168/2
or the doc example in https://circleci.com/docs/2.0/workflows/#using-workspaces-to-share-data-among-jobs

@cmharlow
Copy link
Contributor

Thanks @linuxswords ! Always helpful to have other eyes looking to simplify + improve our code configs 👍

Copy link
Contributor

@jcoyne jcoyne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you.

Copy link
Contributor

@cmharlow cmharlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, want at least 1 dev to check behind though.

@jcoyne jcoyne merged commit 839755e into sul-dlss-deprecated:master Jun 18, 2018
@linuxswords linuxswords deleted the cirecleci-config-refactor branch June 18, 2018 17:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants