Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display MODS title(s) in the body of the MODS view modal #3615

Closed
andrewjbtw opened this issue Apr 29, 2022 · 0 comments · Fixed by #3624
Closed

Display MODS title(s) in the body of the MODS view modal #3615

andrewjbtw opened this issue Apr 29, 2022 · 0 comments · Fixed by #3624
Assignees

Comments

@andrewjbtw
Copy link

This came up when looking at items with parallel titles. The MODS view modal that pops up when you click on the MODS button in Argo is splitting up where it shows title information when there are multiple titles. The first title is going into the header of the modal and other titles are displaying below.

Screen Shot 2022-04-29 at 12 50 08 PM

Example above taken from: https://argo.stanford.edu/view/gn988hy1229

In that example, the whole title is the combination of the title above the modal header and the title under the "Title". That's pretty confusing.

To cut down confusion, let's change the MODS modal to:

  1. Always put the title in the body of the modal, under the heading "Title"
  2. Put a generic header at the top of the modal, like "View descriptive metadata" (since it won't always be generated from MODS i in the future)

The latter change will also meet the requirements of #635

@jcoyne jcoyne added question and removed question labels May 2, 2022
@jcoyne jcoyne self-assigned this May 2, 2022
jcoyne added a commit that referenced this issue May 2, 2022
Previously the title was in the header.
Fixes #3615
Fixes #635
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants