Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use component-library styles #4539

Merged
merged 3 commits into from
Jul 30, 2024
Merged

Use component-library styles #4539

merged 3 commits into from
Jul 30, 2024

Conversation

jcoyne
Copy link
Collaborator

@jcoyne jcoyne commented Jul 12, 2024

Why was this change made?

Use the component-library

How was this change tested?

@astridu
Copy link

astridu commented Jul 26, 2024

Button issues
Seeing red buttons and/or links on these page. Buttons should be blue filled or blue outline:

  • Home page: "Show more facets" button should have 1/2" space below it so it doesn't touch the footer.

  • Search results: red outline buttons at the top of search results should be blue outline
    image

  • Impersonate: Cancel should be blue outline

  • All modals: Cancel button is red filled. It should be blue outline.

  • All Workflows: red Select view button and reset links should be blue.

  • Item view: https://argo-qa.stanford.edu/view/druid:bc778pm9866 - Back to search link should be blue

  • Create new APO: add/remove buttons should be blue filled, cancel button should be blue outline

  • Create collection: Register collection should be blue filled, and cancel button should be blue outline

  • Manage tags: garbage can icon should be blue, cancel button should be blue outline

  • Accession workflow, Preservation ingest wf, Versioning wf: 'Set to completed' buttons should be blue filled, cancel button should be blue outline

  • Register APO: Cancel button should be blue outline. Add/remove should be blue filled.

Other issues

In design component library:
image

  • New bulk action: The 'back' links should be to the right of the Submit button, not below it.
  • Registration: The Register button at the bottom should have some space below it so it's not touching the footer.

@astridu
Copy link

astridu commented Jul 29, 2024

This is looking amazing! Thanks for taking the time and care to go through all of these. A few things:

  1. the garbage can icons should be blue, but I'm not sure if we've specified icon colors in the component library yet.
  2. the 'back' links on bulk actions: On second thought, this should probably be a Submit (blue filled button) and Cancel (outline button) to the right of it to be consistent with the Register actions.
  3. the 'Register' button on Register items is still hitting the bottom of the page. Could we give it some space so it's not touching the footer? Could we also put a blue outline 'Cancel' button to the right of the 'Register' button to make it consistent with the other Register actions?
  4. Could we make the 'cancel' link on the Register agreement page a blue outline button and to the right of the 'Create agreement' button?
  5. I also missed the facet buttons on the search results page. Those are still showing red, but Darcy defined a specific style for pills that I'm not sure are in the component library yet.

@jcoyne jcoyne force-pushed the component-library branch 2 times, most recently from 9be8c7d to 97aa0a3 Compare July 29, 2024 21:13
@jcoyne
Copy link
Collaborator Author

jcoyne commented Jul 29, 2024

@astridu

These are now down aside from these two which I have ticketed separately as they are substantial additional work:

the 'back' links on bulk actions: On second thought, this should probably be a Submit (blue filled button) and Cancel (outline button) to the right of it to be consistent with the Register actions.

I also missed the facet buttons on the search results page. Those are still showing red, but Darcy defined a specific style for pills that I'm not sure are in the component library yet.

@jcoyne jcoyne changed the title [HOLD] Use component-library styles Use component-library styles Jul 29, 2024
@justinlittman justinlittman merged commit 4b167b7 into main Jul 30, 2024
7 checks passed
@justinlittman justinlittman deleted the component-library branch July 30, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants