Freeze all the strings

This will help us be prepared for Ruby 3

.rubocop.yml

@@ -60,9 +60,6 @@ RSpec/MultipleExpectations:
 RSpec/NestedGroups:
   Max: 4 # default: 3
 
-Style/FrozenStringLiteralComment:
-  Enabled: false
-
 Style/NumericPredicate: # "> 0" is not less readable than ".positive?"
   Enabled: false
 

app/channels/application_cable/channel.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ApplicationCable
   class Channel < ActionCable::Channel::Base
   end

app/channels/application_cable/connection.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ApplicationCable
   class Connection < ActionCable::Connection::Base
   end

app/controllers/application_controller.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class ApplicationController < ActionController::Base
   before_action :authenticate_user! # ensures that remote user is logged in locally (via database)
 end

app/controllers/bundle_contexts_controller.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class BundleContextsController < ApplicationController
   def new
     @bundle_context = BundleContext.new(

app/controllers/job_runs_controller.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class JobRunsController < ApplicationController
   def create
     raise ActionController::ParameterMissing, :bundle_context_id unless job_run_params[:bundle_context_id]

app/helpers/application_helper.rb

@@ -1,2 +1,4 @@
+# frozen_string_literal: true
+
 module ApplicationHelper
 end

app/jobs/application_job.rb

@@ -1,2 +1,4 @@
+# frozen_string_literal: true
+
 class ApplicationJob < ActiveJob::Base
 end

app/jobs/discovery_report_job.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class DiscoveryReportJob < ApplicationJob
   queue_as :discovery_report
 

app/jobs/preassembly_job.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class PreassemblyJob < ApplicationJob
   queue_as :preassembly
 

app/lib/csv_importer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class CsvImporter
   # load CSV allowing UTF-8 to pass through, deleting blank columns
   # @param [String] filename

app/lib/pre_assembly/assembly_directory.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module PreAssembly
   # Represents the assembly structure on the filesystem
   class AssemblyDirectory

app/lib/pre_assembly/bundle.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module PreAssembly
   class Bundle
     include PreAssembly::Logging

app/lib/pre_assembly/content_metadata_creator.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module PreAssembly
   class ContentMetadataCreator
     def initialize(druid_id:, content_md_creation:, object_files:, content_md_creation_style:, media_manifest:)

app/lib/pre_assembly/copy_stager.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module PreAssembly
   class CopyStager
     def self.stage(source, destination)

app/lib/pre_assembly/digital_object.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module PreAssembly
   class DigitalObject
     include PreAssembly::Logging

app/lib/pre_assembly/link_stager.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module PreAssembly
   class LinkStager
     def self.stage(source, destination)

app/lib/pre_assembly/logging.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module PreAssembly
   module Logging
     LEVELS = {
@@ -8,8 +10,8 @@ module Logging
       debug: Logger::DEBUG
     }.freeze
 
-    LOG_FORMAT    = "%-6s -- %s -- %s\n".freeze
-    TIME_FORMAT   = '%Y-%m-%d %H:%M:%S'.freeze
+    LOG_FORMAT    = "%-6s -- %s -- %s\n"
+    TIME_FORMAT   = '%Y-%m-%d %H:%M:%S'
 
     @@log       ||= Logger.new(File.join(Rails.root, 'log', "#{Rails.env}.log"))
     @@log.level   = LEVELS[:info]

app/lib/pre_assembly/media.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # This class generates contentMetadata from a Media supplied manifest
 # see the "SMPL Content" section here for a description of the manifest:
 # https://consul.stanford.edu/pages/viewpage.action?pageId=136365158#AutomatedAccessioningandObjectRemediation(pre-assemblyandassembly)-SMPLContent

app/lib/pre_assembly/media_project_technical_metadata_creator.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module PreAssembly
   # Looks for *_techmd.xml files in the bundle_dir and concatenates them
   class MediaProjectTechnicalMetadataCreator

app/lib/pre_assembly/object_file.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module PreAssembly
   class ObjectFile < Assembly::ObjectFile
     include ActiveModel::AttributeMethods

app/mailers/application_mailer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class ApplicationMailer < ActionMailer::Base
   default from: 'no-reply-preassembly@.stanford.edu'
   layout 'mailer'

app/mailers/job_mailer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class JobMailer < ApplicationMailer
   default from: 'no-reply-preassembly-job@stanford.edu'
 

app/models/application_record.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class ApplicationRecord < ActiveRecord::Base
   self.abstract_class = true
 end

app/models/bundle_context.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class BundleContext < ApplicationRecord
   belongs_to :user
   has_many :job_runs, dependent: :destroy

app/models/job_run.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class JobRun < ApplicationRecord
   belongs_to :bundle_context
   validates :job_type, presence: true

app/models/user.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class User < ApplicationRecord
   devise :remote_user_authenticatable # We don't want other (default) Devise modules
   has_many :bundle_contexts, dependent: :destroy

app/services/discovery_report.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Previously a single untested 200-line method from ./lib/pre_assembly/reporting.rb
 # Takes a Bundle, enumerates report data via #each_row
 class DiscoveryReport

app/services/object_file_validator.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class ObjectFileValidator
   def initialize(object:, bundle:)
     @object = object

config/application.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'boot'
 require 'rails/all'
 

config/boot.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 ENV['BUNDLE_GEMFILE'] ||= File.expand_path('../Gemfile', __dir__)
 
 require 'bundler/setup' # Set up gems listed in the Gemfile.

config/deploy.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 set :application, 'pre-assembly'
 set :repo_url, 'ssh://git@github.com/sul-dlss/pre-assembly'
 

config/deploy/prod.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 server 'sul-preassembly-prod.stanford.edu', user: 'preassembly', roles: %w[web app db]
 
 Capistrano::OneTimeKey.generate_one_time_key!

config/deploy/stage.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 server 'sul-preassembly-stage.stanford.edu', user: 'preassembly', roles: %w[web app db]
 
 Capistrano::OneTimeKey.generate_one_time_key!

config/environment.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Load the Rails application.
 require_relative 'application'
 

config/initializers/application_controller_renderer.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # Be sure to restart your server when you modify this file.
 
 # ActiveSupport::Reloader.to_prepare do

config/initializers/assets.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Be sure to restart your server when you modify this file.
 
 # Version of your assets, change this if you want to expire all your assets.

config/initializers/backtrace_silencers.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # Be sure to restart your server when you modify this file.
 
 # You can add backtrace silencers for libraries that you're using but don't wish to see in your backtraces.

config/initializers/config.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 Config.setup do |config|
   # Name of the constant exposing loaded settings
   config.const_name = 'Settings'

config/initializers/content_security_policy.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # Be sure to restart your server when you modify this file.
 
 # Define an application-wide content security policy

config/initializers/cookies_serializer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Be sure to restart your server when you modify this file.
 
 # Specify a serializer for the signed and encrypted cookie jars.

config/initializers/dor_config.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'dor-services'
 
 Dor::Config.configure do

config/initializers/filter_parameter_logging.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Be sure to restart your server when you modify this file.
 
 # Configure sensitive parameters which will be filtered from the log file.

config/initializers/inflections.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # Be sure to restart your server when you modify this file.
 
 # Add new inflection rules using the following format. Inflections

config/initializers/load_config.rb

@@ -1,2 +1,4 @@
+# frozen_string_literal: true
+
 bundle_dir_roots = YAML.safe_load(ERB.new(File.read("#{Rails.root}/config/initializers/bundle_dir_roots.yml.erb")).result)[Rails.env]
 ALLOWABLE_BUNDLE_DIRS = bundle_dir_roots.map { |path| path.chomp('/') }

config/initializers/mime_types.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # Be sure to restart your server when you modify this file.
 
 # Add new mime types for use in respond_to blocks:

config/initializers/okcomputer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # by default, okcomputer does "app up?" and "database conntected?" checks
 OkComputer.mount_at = 'status' # use /status or /status/all or /status/<name-of-check>
 OkComputer.check_in_parallel = true

config/initializers/resque.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'resque/failure/redis_multi_queue'
 
 # load environment specific configuration

config/initializers/wrap_parameters.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Be sure to restart your server when you modify this file.
 
 # This file contains settings for ActionController::ParamsWrapper which

config/puma.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Puma can serve each request in a thread from an internal thread pool.
 # The `threads` method setting takes two numbers: a minimum and maximum.
 # Any libraries that use thread pools should be configured to match

config/routes.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'resque/server'
 Rails.application.routes.draw do
   # For details on the DSL available within this file, see http://guides.rubyonrails.org/routing.html

config/spring.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 %w[
   .ruby-version
   .rbenv-vars

lib/dev_shibboleth_headers.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # This is a Rack middleware that we use in development. It sets an env var in such a way as to
 # simulate the way mod_shib injects request headers that then result in an env var being set
 # for the request.

lib/tasks/resque.rake

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'resque/tasks'
 task 'resque:setup' => :environment
 

spec/controllers/bundle_contexts_controller_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 RSpec.describe BundleContextsController, type: :controller do
   let(:params) do
     {

spec/controllers/job_runs_controller_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 RSpec.describe JobRunsController, type: :controller do
   let(:bc) { create(:bundle_context_with_deleted_output_dir) }
 

spec/factories/bundle_contexts.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 FactoryBot.define do
   factory :bundle_context do
     bundle_dir { 'spec/test_data/multimedia' }

spec/factories/job_runs.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 FactoryBot.define do
   factory :job_run do
     job_type { 'discovery_report' }

spec/factories/users.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 FactoryBot.define do
   factory :user do
     sequence(:sunet_id) { |n| "fake_#{n}" }

spec/jobs/discovery_report_job_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 RSpec.describe DiscoveryReportJob, type: :job do
   let(:job) { described_class.new }
   let(:job_run) { create(:job_run) }

spec/jobs/preassembly_job_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 RSpec.describe PreassemblyJob, type: :job do
   let(:job) { described_class.new }
   let(:job_run) { create(:job_run) }

spec/lib/csv_importer_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 RSpec.describe CsvImporter do
   describe '#parse_to_hash' do
     let(:manifest) do

spec/lib/pre_assembly/assembly_directory_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 RSpec.describe PreAssembly::AssemblyDirectory do
   subject(:object) { described_class.new(druid_id: 'gn330dv6119') }
 

spec/lib/pre_assembly/bundle_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 RSpec.describe PreAssembly::Bundle do
   let(:md5_regex) { /^[0-9a-f]{32}$/ }
   let(:flat_dir_images) { bundle_setup(:flat_dir_images) }

spec/lib/pre_assembly/content_metadata_creator_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 RSpec.describe PreAssembly::ContentMetadataCreator do
   subject(:object) do
     described_class.new(druid_id: druid_id,