Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disc report: get error to user for missing container name or manifest #527

Merged
merged 2 commits into from
Aug 23, 2019
Merged

disc report: get error to user for missing container name or manifest #527

merged 2 commits into from
Aug 23, 2019

Conversation

ndushay
Copy link
Contributor

@ndushay ndushay commented Aug 22, 2019

due to Honeybadger https://app.honeybadger.io/projects/52900/faults/46820737

image

Note: I am not 100% sure of the error structure. @jmartin-sul - care to review?

@coveralls
Copy link

coveralls commented Aug 22, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.4%) to 89.142% when pulling 07c4fbe on better-errs into 9d83cd6 on master.

@jmartin-sul jmartin-sul merged commit 37cd03f into master Aug 23, 2019
@jmartin-sul jmartin-sul deleted the better-errs branch August 23, 2019 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmartin-sul jmartin-sul jmartin-sul approved these changes

Assignees

@jmartin-sul jmartin-sul

Labels
tech debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ndushay @coveralls @jmartin-sul