add devel script for copying files from the stacks to a new loca… #543
Conversation
|
This doesn't seem to have anything to do with assembly. Is this the correct repository? Have you considered PURL or Stacks? |
|
My opinion is that this code falls into "scripty" category - the types of scripts in the past have collected in the pre-assembly codebase, as that is deployed to a server that has access to basically all mounts and services and is configured to do this. It is not out of the realm of possibilities that this script could be extended to involve fetching info not associated with stacks or PURL (and it already touches both, making it ambiguous which of those two repos it would go in). Suggest we discuss in the next meeting about strategies for when a script/rake task gets put in a specific repo that it is directly related to vs the "script" location. |
| # Copies files from the stacks into a separate folder given a list of druids | ||
| # Pass into the full path to the input CSV below and the full path to the output location. | ||
| # The input CSV must have a column called 'druid' containing the druid, other columns are ignored | ||
| # August 29, 2019 |
There was a problem hiding this comment.
Could you please indicate who requested it and the context too?
There was a problem hiding this comment.
Yes, If we don't have tests, I would like to know, how long do we have to support this and who is in charge of authoring/testing changes that need to be made. Ideally this would have a sunset date after which we can delete.
There was a problem hiding this comment.
added some comments/context
There was a problem hiding this comment.
Can you explain why this script has to circumvent the existing APIs to accomplish what it needs to?
There was a problem hiding this comment.
You mean public APIs, like crawling PURL pages, and downloading content from the stacks? Or dor-services-app APIs? Either way, it was just expediency under the presumption it is possibly a one-timeish request. If it turns out not to be, then it could be more formalized.
There was a problem hiding this comment.
Okay, in that case, can we add "This work was done as a one time request and does not need to be maintained" in the documentation?
There was a problem hiding this comment.
Sure, done. I'd also like to see us agree on a general strategy for these types of requested scripts to minimize time spent on them. For example, a general README in this "devel" folder (assuming that is the specified place) that stipulates the scripts are generally unsupported and untested, and not suitable for regular production usage.
peetucket
force-pushed
the
get-files-from-stacks
branch
from
c0baa90
to
cec9ecc
Compare
peetucket
changed the title
a simple script used for AI work, given a CSV with a list of druids, will copy all of the files from the stacks for each druid (as well as the MODs files from the purl cache) to another location