-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Permit connection error in place of stream error #10
Comments
Nice catch! I had overlooked about that. |
Fixed. |
Thank you for the quick fix! |
As an afterthought, it might be worth to consider adding a strict mode that permits the peer to send connection errors (or to just close the connection) in place of stream errors. note: draft-16 6.8 states: "An endpoint might choose to close a connection without sending GOAWAY for misbehaving peers", which IMO means that it is permitted for an implementation compliant to the spec to abruptly close the connection for any of the connection errors or stream errors, taking the statement in 5.4.1 (shown above) into consideration. |
Draft-16 5.4.1 states:
Looking at https://github.com/summerwind/h2spec/search?utf8=✓&q=rststreamframe there seems to be three tests that expect RST_STREAM, but the two tests (6_9, 8_1) do not permit GOAWAY frames used in place.
The text was updated successfully, but these errors were encountered: