Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permit connection error in place of stream error #10

Closed
kazuho opened this issue Jan 18, 2015 · 4 comments
Closed

Permit connection error in place of stream error #10

kazuho opened this issue Jan 18, 2015 · 4 comments

Comments

@kazuho
Copy link
Contributor

kazuho commented Jan 18, 2015

Draft-16 5.4.1 states:

In particular, an endpoint MAY choose to treat a stream error as a connection error.

Looking at https://github.com/summerwind/h2spec/search?utf8=✓&q=rststreamframe there seems to be three tests that expect RST_STREAM, but the two tests (6_9, 8_1) do not permit GOAWAY frames used in place.

@summerwind
Copy link
Owner

Nice catch! I had overlooked about that.
I will change codes soon.

@summerwind
Copy link
Owner

Fixed.
If you still have a problem, please reopen this issue.

@kazuho
Copy link
Contributor Author

kazuho commented Jan 19, 2015

Thank you for the quick fix!

@kazuho
Copy link
Contributor Author

kazuho commented Jan 19, 2015

As an afterthought, it might be worth to consider adding a strict mode that permits the peer to send connection errors (or to just close the connection) in place of stream errors.

note: draft-16 6.8 states: "An endpoint might choose to close a connection without sending GOAWAY for misbehaving peers", which IMO means that it is permitted for an implementation compliant to the spec to abruptly close the connection for any of the connection errors or stream errors, taking the statement in 5.4.1 (shown above) into consideration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants