Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix several issues with last PRs #50

Merged
merged 6 commits into from
Jan 4, 2018
Merged

Conversation

mrheinen
Copy link
Contributor

@mrheinen mrheinen commented Jan 2, 2018

Ok this fixes 5 problems:

  • The CMakeLists.txt file contained a typo
  • The updated transactions call was using an outdated interface.
  • The simplewallet did not build due to incorrect refresh calls.
  • Missing return statement in net_helper
  • Unused variable was removed

@mrheinen mrheinen changed the title Fix a typo in the CMakeLists comments. Fix issues with last PRs Jan 2, 2018
@mrheinen mrheinen changed the title Fix issues with last PRs WIP: Fix issues with last PRs Jan 2, 2018
These refresh calls (and the original ones) are not needed. The wallet
will refresh automatically once ->run() is called.
@mrheinen mrheinen changed the title WIP: Fix issues with last PRs Fix several issues with last PRs Jan 2, 2018
@mrheinen
Copy link
Contributor Author

mrheinen commented Jan 2, 2018

Attached is a build log showing that it now builds without warnings or errors.

build.log

@alebeta90
Copy link

thanks! you are solving the error i got today compiling

@haruto-tanno
Copy link
Contributor

That works fine, ready for merging. Thanks

@sumoprojects sumoprojects merged commit e07b603 into sumoprojects:master Jan 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants