Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatible with latest core.async #9

Closed
sunng87 opened this issue Apr 25, 2020 · 1 comment
Closed

Incompatible with latest core.async #9

sunng87 opened this issue Apr 25, 2020 · 1 comment

Comments

@sunng87
Copy link
Owner

sunng87 commented Apr 25, 2020

lein test :only rigui.async-test/test-delayed-chan

FAIL in (test-delayed-chan) (async_test.cljc:22)
base case
expected: (= port d-chan)
  actual: (not (= #object[clojure.core.async.impl.channels.ManyToManyChannel 0x1672c2a4 "clojure.core.async.impl.channels.ManyToManyChannel@1672c2a4"] #object[rigui.async.DelayedChannel 0x66ac57cf "rigui.async.DelayedChannel@66ac57cf"]))

lein test :only rigui.async-test/test-delayed-chan

FAIL in (test-delayed-chan) (async_test.cljc:23)
base case
expected: (= v :a)
  actual: (not (= nil :a))

Test cases failed with latest core.async 1.1.587

@sunng87
Copy link
Owner Author

sunng87 commented Apr 26, 2020

The timeout precision was cut in recent version of core.async. If we add a little bit more tolerance in test it will be ok,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant