Updating GOES 18 and 19 temperature and emission measure #178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fixes #144 - i'll add some more tests now too. This now works as the latest chianti file that is pulled from hesperia includes the tables for GOES18 and 18 |
nabobalis
reviewed
Jul 8, 2025
changelog/178.bugfix.rst
Outdated
| @@ -0,0 +1 @@ | |||
| Updating the maximum supported GOES satellite to GOES 19 for the temperature and emission measure calculation. No newline at end of file | |||
|
Online test failure is unrelated, fixed in another PR. |
nabobalis
approved these changes
Jul 9, 2025
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
|
This is an after-the-fact comment, but why are we only testing up to GOES-18 when we say we support up to 19? |
|
We can add another test for GOES 19. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it should just work ...