Skip to content

Conversation

nabobalis
Copy link
Member

Hek changed, so I am updating the code to account for that.

It has backwards compatibility with older sunpy releases.

@nabobalis nabobalis enabled auto-merge (squash) July 8, 2025 22:30
Comment on lines +73 to +76
if sunpy_version < "7.0.0":
event_coord = (r["event_coord1"], r["event_coord2"])
else:
event_coord = (r["event_coord"])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could just use the raw attribute on the results to get back the pre 7.0.0 output.

Copy link
Member

@wtbarnes wtbarnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with me. Using the raw attribute and then dealing with 7.0 and above later would also work but this is so few code changes it probably doesn't matter.

@nabobalis nabobalis merged commit 58a2058 into main Jul 9, 2025
16 checks passed
@nabobalis nabobalis deleted the fix branch July 9, 2025 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants