Skip to content

add back central doc api #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 14, 2022
Merged

add back central doc api #84

merged 1 commit into from
Oct 14, 2022

Conversation

nabobalis
Copy link
Member

@nabobalis nabobalis commented Oct 14, 2022 •
edited
Loading

Check to see if it renders nice first before merge.

@nabobalis nabobalis added the No Changelog Entry Needed Skip all changelog checks. label Oct 14, 2022
@nabobalis nabobalis merged commit 0178005 into main Oct 14, 2022
@nabobalis nabobalis deleted the docs branch October 14, 2022 18:52
dstansby
dstansby suggested changes Oct 14, 2022
View reviewed changes
Copy link
Contributor

@dstansby dstansby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is right - there's no point documenting sunkit_instruments when there's nothing there. Instead a sphinx reference to sunkit_instruments on the index page is a better option.

@nabobalis
Copy link
Member Author

It worked before and there is stuff there. There is no code but there is a nice summary in the main doc for the init.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@dstansby dstansby dstansby requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

No Changelog Entry Needed Skip all changelog checks.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nabobalis @dstansby