Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When instantiating a frame, use obstime from observer if obstime not otherwise provided #7186

Merged
merged 1 commit into from
Oct 9, 2023
Merged

When instantiating a frame, use obstime from observer if obstime not otherwise provided #7186

merged 1 commit into from
Oct 9, 2023

Conversation

ayshih
Copy link
Member

@ayshih ayshih commented Sep 8, 2023 •
edited
Loading

See title and #7185

I also removed a docstring example from get_body_heliographic_stonyhurst() because it's unclear what the intended transformation is given the mismatch in obstime. The example doesn't show off anything about get_body_heliographic_stonyhurst() anyway.

@ayshih ayshih added coordinates Affects the coordinates submodule No Backport A PR that isn't to be backported to any release branch. (To be used as a flag to other maintainers) labels Sep 8, 2023
@ayshih ayshih mentioned this pull request Sep 8, 2023
Closed
@ayshih ayshih marked this pull request as ready for review September 8, 2023 14:03
@ayshih ayshih requested a review from a team as a code owner September 8, 2023 14:03
dstansby
dstansby reviewed Sep 13, 2023
View reviewed changes
Copy link
Member

@dstansby dstansby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks 👍 , just two minor suggestions.

sunpy/coordinates/frames.py Show resolved Hide resolved
sunpy/coordinates/tests/test_frames.py Show resolved Hide resolved
@ayshih ayshih added the Needs Review Needs reviews before merge label Sep 15, 2023
@wtbarnes wtbarnes added this to the 5.1.0 milestone Oct 4, 2023
@Cadair Cadair merged commit 92e7f62 into sunpy:main Oct 9, 2023
19 of 20 checks passed
@ayshih ayshih deleted the obstime_from_observer branch October 25, 2023 20:20
@nabobalis nabobalis removed the Needs Review Needs reviews before merge label Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dstansby dstansby dstansby approved these changes

@Cadair Cadair Cadair approved these changes

Assignees
No one assigned
Labels
coordinates Affects the coordinates submodule No Backport A PR that isn't to be backported to any release branch. (To be used as a flag to other maintainers)
Projects
None yet
Milestone
5.1.0
Development

Successfully merging this pull request may close these issues.
5 participants
@ayshih @Cadair @dstansby @nabobalis @wtbarnes