chore: pretty print poc

.cargo/config.toml

@@ -0,0 +1,2 @@
+[alias]
+xtask = "run -p xtask --"

Cargo.toml

@@ -1,5 +1,13 @@
 [workspace]
-members  = ["crates/*", "lib/*", "xtask/codegen", "xtask/rules_check", "docs/codegen"]
+members = [
+  "crates/*",
+  "lib/*",
+  "xtask/codegen",
+  "xtask/rules_check",
+  "xtask/agentic",
+  "xtask/download_regression_tests",
+  "docs/codegen",
+]
 resolver = "2"
 
 [workspace.package]
@@ -23,7 +31,9 @@ biome_js_syntax          = "0.5.7"
 biome_rowan              = "0.5.7"
 biome_string_case        = "0.5.8"
 bpaf                     = { version = "0.9.15", features = ["derive"] }
+camino                   = "1.1.9"
 crossbeam                = "0.8.4"
+dir-test                 = "0.4.1"
 enumflags2               = "0.7.11"
 ignore                   = "0.4.23"
 indexmap                 = { version = "2.6.0", features = ["serde"] }
@@ -78,6 +88,8 @@ pgt_lexer_codegen          = { path = "./crates/pgt_lexer_codegen", version = "0
 pgt_lsp                    = { path = "./crates/pgt_lsp", version = "0.0.0" }
 pgt_markup                 = { path = "./crates/pgt_markup", version = "0.0.0" }
 pgt_plpgsql_check          = { path = "./crates/pgt_plpgsql_check", version = "0.0.0" }
+pgt_pretty_print           = { path = "./crates/pgt_pretty_print", version = "0.0.0" }
+pgt_pretty_print_codegen   = { path = "./crates/pgt_pretty_print_codegen", version = "0.0.0" }
 pgt_query                  = { path = "./crates/pgt_query", version = "0.0.0" }
 pgt_query_ext              = { path = "./crates/pgt_query_ext", version = "0.0.0" }
 pgt_query_macros           = { path = "./crates/pgt_query_macros", version = "0.0.0" }

STATE.md

@@ -0,0 +1,56 @@
+# Pretty Print Formatter State
+
+## Current Phase: Code Quality Improvements - COMPLETED ✅
+
+## Last Completed Work
+- Fixed all forbidden patterns in nodes.rs:
+  - Removed length-based formatting logic (e.g., `if items.len() > 3`)
+  - Eliminated manual child node parsing patterns (e.g., `if let Some(pgt_query::protobuf::node::Node::List(list))`)
+  - Enhanced List implementation with context-aware formatting
+- Added helper functions for common string formatting patterns
+- Cleaned up ObjectOpfamily/ObjectOpclass handling
+- Fixed clippy warnings and compilation errors
+
+## Issues Found and Fixed
+
+### 1. Length-based Formatting ✅ FIXED
+- **Issue**: Code changing formatting behavior based on list length
+- **Locations**: InsertStmt (line 1159), AExprList (line 1258)
+- **Solution**: Use consistent formatting with SoftOrSpace, let renderer decide breaks
+
+### 2. Manual Child Node Parsing ✅ FIXED
+- **Issue**: Parent nodes manually inspecting child node types instead of calling `to_tokens()`
+- **Locations**: 
+  - DropStmt (line 1742)
+  - RangeFunction (line 2228) 
+  - DefElem instances (lines 3019, 3100, 3172, 3277)
+  - RenameStmt (line 6314)
+  - AlterObjectSchemaStmt (line 6489)
+  - AlterOwnerStmt (line 6581)
+- **Solution**: Use `node.to_tokens(e)` and enhanced List context handling
+
+### 3. Code Quality Improvements ✅ FIXED
+- Added EventEmitter helper methods for string formatting
+- Consolidated identical if blocks in List implementation
+- Fixed clippy warnings (collapsible if/else, unused code, etc.)
+- Improved ObjectOpfamily/ObjectOpclass logic with cleaner pattern matching
+
+## Architecture Improvements Made
+- **Proper separation of concerns**: Parent nodes call `child.to_tokens(e)`
+- **Context-aware child formatting**: List node uses EventEmitter context functions
+- **Helper functions**: Common string formatting patterns abstracted
+- **Consistent patterns**: No hardcoded conditional logic based on lengths or types
+
+## Documentation Updates
+- Updated `agentic/pretty_printer.md` with new forbidden patterns
+- Added string formatting helper guidance
+- Added manual child node parsing prevention rules
+
+## Code Quality Status
+- All forbidden patterns eliminated ✅
+- Clippy warnings addressed ✅
+- Compilation successful ✅
+- Architecture follows clean separation of concerns ✅
+
+## Notes for Resumption
+This architectural cleanup phase is complete. All forbidden patterns have been eliminated and the codebase now follows proper parent-child delegation patterns with context-aware formatting. The next phase would be to continue with the main formatting task using the improved, clean architecture.