feat(typecheck): also replace longer type defaults #541
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juleswritescode
commented
Sep 27, 2025
Comment on lines
-335
to
+322
| // all values of the enums are longer than `NULL`, so we use `NULL` instead | ||
| "select 0 + 0 + 0 + 0 + 0 + NULL " | ||
| "select 0 + 0 + 0 + 0 + 0 + 'critical'" |
There was a problem hiding this comment.
not sure if the change from NULL to 'critical' is desired?
There was a problem hiding this comment.
yes, makes sense after your change
juleswritescode
commented
Sep 27, 2025
psteinroe
approved these changes
Sep 29, 2025
Comment on lines
-335
to
+322
| // all values of the enums are longer than `NULL`, so we use `NULL` instead | ||
| "select 0 + 0 + 0 + 0 + 0 + NULL " | ||
| "select 0 + 0 + 0 + 0 + 0 + 'critical'" |
There was a problem hiding this comment.
yes, makes sense after your change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, we would only show type errors if the length of the default-type-value was <= than the length of the param-name it belonged to.
Now we have an API that tracks positions in text replacements even if they grow the original text, so we can show such errors: