fix: fetch json_library option on compile-time #74
+7
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We've introduced the
json_library
config option but only applied it to the main library (this one)Trying to override on the other ones, it got shown that we need a compile-time value since other libraries - like
storage-ex
derives theEncoder
protocol for structs, so a runtime value can't be usedSolution
Transform the option on compile-time, so users need to set it on
config.exs
exactly like the phoenix library does (although it may fetch fom runtime too)Rationale