Skip to content

feat: Add functions #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Oct 10, 2022
Merged

feat: Add functions #179

merged 13 commits into from
Oct 10, 2022

Conversation

J0
Copy link
Contributor

@J0 J0 commented Mar 31, 2022

TODO:

  • Update dep/lock file

@J0 J0 changed the title Add fns Add magic Mar 31, 2022
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Mar 31, 2022

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 11.84%.

Quality metrics Before After Change
Complexity 0.82 ⭐ 2.05 ⭐ 1.23 👎
Method Length 33.08 ⭐ 43.00 ⭐ 9.92 👎
Working memory 5.87 ⭐ 9.68 🙂 3.81 👎
Quality 81.77% 69.93% 🙂 -11.84% 👎
Other metrics Before After Change
Lines 172 173 1
Changed files Quality Before Quality After Quality Change
supabase/client.py 79.11% ⭐ 69.93% 🙂 -9.18% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
supabase/client.py Client.__init__ 4 ⭐ 193 😞 15 😞 47.09% 😞 Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@J0 J0 changed the title Add magic Add functions Mar 31, 2022
@codecov
Copy link

codecov bot commented Oct 10, 2022

Codecov Report

Base: 81.06% // Head: 82.26% // Increases project coverage by +1.20% 🎉

Coverage data is based on head (47ac882) compared to base (0fdb70d).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #179      +/-   ##
===========================================
+ Coverage    81.06%   82.26%   +1.20%     
===========================================
  Files            8        8              
  Lines          132      141       +9     
===========================================
+ Hits           107      116       +9     
  Misses          25       25              
Impacted Files Coverage Δ
supabase/client.py 92.45% <100.00%> (+1.54%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@J0 J0 marked this pull request as ready for review October 10, 2022 04:38
@J0 J0 changed the title Add functions feat: Add functions Oct 10, 2022
@J0 J0 requested review from leynier, anand2312 and dreinon October 10, 2022 05:19
Copy link
Contributor

@anand2312 anand2312 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for the small missing type hint

Co-authored-by: Anand <40204976+anand2312@users.noreply.github.com>
@J0 J0 merged commit 31ca8d2 into develop Oct 10, 2022
@J0 J0 deleted the j0_add_magic branch October 10, 2022 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants