fix: add shouldCreateUser field to sign in with magiclink

[kangmingtay]

What kind of change does this PR introduce?

• Keep gotrue-js in-sync with fix: add create_user field to otp endpoint auth#318
• Adds a shouldCreateUser param for the signIn method
• Fixes auth.signIn() with magic link creates users in Auth.users table supabase#1176 (comment)

[kangmingtay]

Just wondering if it will be confusing to name the param noSignup inside the signIn method since noSignup only affects magiclinks or otps. IMO i think it might be confusing if developers expect it to apply to all types of sign-in methods including the signing in with an external oauth provider.

Would a more explicit name such as noOtpSignup be clearer?

Decided to go with adding a shouldCreateUser option to the signIn method. The only concern i have is the shouldCreateUser option only applies to magiclink sign-ins. I wonder if this makes the DX confusing for devs using the signIn method for other types of sign-in (e.g social providers / password-based).

[thorwebdev]

Just a small nit regarding typedoc comment.

[thorwebdev]

Can you add this to the @param comments above for the docs.

[kangmingtay]

sure, yeah i think this would also help to make it clear that the shouldCreateUser flag can only be used for magiclinks / otp sign-ins

[github-actions]

🎉 This PR is included in version 1.22.2 🎉

The release is available on:

• GitHub release
• npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

[kristjanmar]

This is not working, unfortunately. The user gets added when typing an email into the login form even when the flag is activated.

async function signIn(email: string) {
	const { error } = await supabase.auth.signIn({
		email,
		shouldCreateUser: false
	})
	return { error }
}

I've tried shouldCreateUser, create_user and noSignup as the flag, since it is unclear which one it's supposed to be. But none of them work.