fix: remove phone mfa deletion, match on error codes #963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
J0
commented
Sep 26, 2024
src/GoTrueClient.ts
Outdated
| if ( | ||
| error?.message === 'Identity is already linked' || | ||
| error?.message === 'Identity is already linked to another user' | ||
| error?.code === identity_already_exists |
There was a problem hiding this comment.
Relevant error code mapping:https://github.com/supabase/auth/blob/ba00f75c28d6708ddf8ee151ce18f2d6193689ef/internal/api/identity.go#L118
J0
commented
Sep 26, 2024
| @@ -2388,11 +2385,6 @@ export default class GoTrueClient { | |||
| return { data: null, error } | |||
| } | |||
|
|
|||
| // TODO: Remove once: https://github.com/supabase/auth/pull/1717 is deployed | |||
| if (params.factorType === 'phone') { | |||
There was a problem hiding this comment.
TOTP object should now be null since v2.158.1 is deployed (we are now on v2.160.0)
To verify this go to Settings > Infrastructure
J0
commented
Sep 26, 2024
kangmingtay
approved these changes
Sep 26, 2024
kangmingtay
pushed a commit
that referenced
this pull request
Oct 15, 2024
🤖 I have created a release *beep* *boop* --- ## [2.65.1](v2.65.0...v2.65.1) (2024-10-14) ### Bug Fixes * Call `SIGNED_OUT` event where session is removed ([#854](#854)) ([436fd9f](436fd9f)) * improve `mfa.enroll` return types ([#956](#956)) ([8a1ec06](8a1ec06)) * move MFA sub types to internal file ([#964](#964)) ([4b7455c](4b7455c)) * remove phone mfa deletion, match on error codes ([#963](#963)) ([ef3911c](ef3911c)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Addresses a few existing TODOs