fix(oauth2): switch to Origin header for request validation #2174
+194
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 17902778499Details
💛 - Coveralls |
hf
approved these changes
Sep 22, 2025
cemalkilic
pushed a commit
that referenced
this pull request
Sep 23, 2025
🤖 I have created a release *beep* *boop* --- ## [2.180.0](v2.179.0...v2.180.0) (2025-09-23) ### Features * add OAuth client type ([#2152](#2152)) ([b118f1f](b118f1f)) * add phone to sms webhook payload ([#2160](#2160)) ([d475ac1](d475ac1)) * background template reloading p1 - baseline decomposition ([#2148](#2148)) ([746c937](746c937)) * config reloading with fsnotify, poller fallback, and signals ([#2161](#2161)) ([c77d512](c77d512)) * enhance issuer URL validation in OAuth server metadata ([#2164](#2164)) ([a9424d2](a9424d2)) * implement OAuth2 authorization endpoint ([#2107](#2107)) ([5318552](5318552)) * **oauth2:** add `/oauth/token` endpoint ([#2159](#2159)) ([a89a0b0](a89a0b0)) * **oauth2:** add admin endpoint to regenerate OAuth client secrets ([#2170](#2170)) ([0bd1c28](0bd1c28)) * **oauth2:** return redirect_uri on GET authorization ([#2175](#2175)) ([b0a0c3e](b0a0c3e)) * **oauth2:** use `id` field as the public client_id ([#2154](#2154)) ([86b7de4](86b7de4)) * **openapi:** add OAuth 2.1 server endpoints and clarify OAuth modes ([#2165](#2165)) ([1f804a2](1f804a2)) * password changed email notification ([#2176](#2176)) ([fe0fd04](fe0fd04)) * support `transfer_sub` in apple id tokens ([#2162](#2162)) ([8a71006](8a71006)) ### Bug Fixes * ensure request context exists in API db operations ([#2171](#2171)) ([060a992](060a992)) * **makefile:** remove invalid @ symbol from shell commands ([#2168](#2168)) ([e6afe45](e6afe45)) * **oauth2:** switch to Origin header for request validation ([#2174](#2174)) ([42bc9ab](42bc9ab)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
issuedat
pushed a commit
that referenced
this pull request
Sep 30, 2025
## Summary Replace `Referer` header validation with `Origin` header in `validateRequestOrigin` function. Referer was unintended at the beginning. Using `Origin` header as it's automatically set by browsers for cross-origin requests. This is a very basic attempt to prevent cross domain malicious calls. Key changes: - Check `Origin` header instead of `Referer` header - Allow empty `Origin` header (for backend/mobile app initiated requests) - Add comprehensive test coverage for new validation behavior
issuedat
pushed a commit
that referenced
this pull request
Sep 30, 2025
🤖 I have created a release *beep* *boop* --- ## [2.180.0](v2.179.0...v2.180.0) (2025-09-23) ### Features * add OAuth client type ([#2152](#2152)) ([b118f1f](b118f1f)) * add phone to sms webhook payload ([#2160](#2160)) ([d475ac1](d475ac1)) * background template reloading p1 - baseline decomposition ([#2148](#2148)) ([746c937](746c937)) * config reloading with fsnotify, poller fallback, and signals ([#2161](#2161)) ([c77d512](c77d512)) * enhance issuer URL validation in OAuth server metadata ([#2164](#2164)) ([a9424d2](a9424d2)) * implement OAuth2 authorization endpoint ([#2107](#2107)) ([5318552](5318552)) * **oauth2:** add `/oauth/token` endpoint ([#2159](#2159)) ([a89a0b0](a89a0b0)) * **oauth2:** add admin endpoint to regenerate OAuth client secrets ([#2170](#2170)) ([0bd1c28](0bd1c28)) * **oauth2:** return redirect_uri on GET authorization ([#2175](#2175)) ([b0a0c3e](b0a0c3e)) * **oauth2:** use `id` field as the public client_id ([#2154](#2154)) ([86b7de4](86b7de4)) * **openapi:** add OAuth 2.1 server endpoints and clarify OAuth modes ([#2165](#2165)) ([1f804a2](1f804a2)) * password changed email notification ([#2176](#2176)) ([fe0fd04](fe0fd04)) * support `transfer_sub` in apple id tokens ([#2162](#2162)) ([8a71006](8a71006)) ### Bug Fixes * ensure request context exists in API db operations ([#2171](#2171)) ([060a992](060a992)) * **makefile:** remove invalid @ symbol from shell commands ([#2168](#2168)) ([e6afe45](e6afe45)) * **oauth2:** switch to Origin header for request validation ([#2174](#2174)) ([42bc9ab](42bc9ab)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Replace
Refererheader validation withOriginheader invalidateRequestOriginfunction. Referer was unintended at the beginning. UsingOriginheader as it's automatically set by browsers for cross-origin requests. This is a very basic attempt to prevent cross domain malicious calls.Key changes:
Originheader instead ofRefererheaderOriginheader (for backend/mobile app initiated requests)