Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: refactor email sending functions #1495

Merged
merged 7 commits into from
Mar 26, 2024
Merged

fix: refactor email sending functions #1495

merged 7 commits into from
Mar 26, 2024

Conversation

J0
Copy link
Contributor

@J0 J0 commented Mar 25, 2024

What kind of change does this PR introduce?

The overall goal of this to expose a unified interface for emails. So that we can potentially implement the Hook as a Custom Mailer. This is to ensure that the impact on the existing code flow is minimal and that we can turn off the Hook easily if needed.

After this change, we can do something similar to:

mailer. := a.Mailer()
if a.config.Hook.Enabled {
    mailer =   a.CustomMailer
} 

and have all Hook logic live in the custom Mailer

Specific changes are:

  • Removes context from mailer as it is currently unused
  • pushes down mailer into respective email sending methods
  • Adds remaining send methods as API methods
  • Fetch OTP Length and MaxFrequency from config
  • Add convenience function for checking if an email was sent within frequency limit
  • push down externalURL and referrer into send function

@J0 J0 changed the title fix: push down mailer to sending fix: initialize mailer only when sending emails Mar 25, 2024
@J0 J0 marked this pull request as ready for review March 25, 2024 12:26
@J0 J0 requested a review from a team as a code owner March 25, 2024 12:26
@J0 J0 changed the title fix: initialize mailer only when sending emails fix: refactor email sending functions Mar 25, 2024
internal/api/mail.go Outdated Show resolved Hide resolved
internal/api/mail.go Outdated Show resolved Hide resolved
J0 and others added 2 commits March 26, 2024 12:31
Co-authored-by: Kang Ming <kang.ming1996@gmail.com>
@J0 J0 merged commit 285c290 into master Mar 26, 2024
2 checks passed
@J0 J0 deleted the j0/pushdown_mailer branch March 26, 2024 04:48
J0 pushed a commit that referenced this pull request Mar 26, 2024
🤖 I have created a release *beep* *boop*
---


##
[2.145.0](v2.144.0...v2.145.0)
(2024-03-26)


### Features

* add error codes
([#1377](#1377))
([e4beea1](e4beea1))
* add kakao OIDC
([#1381](#1381))
([b5566e7](b5566e7))
* clean up expired factors
([#1371](#1371))
([5c94207](5c94207))
* configurable NameID format for SAML provider
([#1481](#1481))
([ef405d8](ef405d8))
* HTTP Hook - Add custom envconfig decoding for HTTP Hook Secrets
([#1467](#1467))
([5b24c4e](5b24c4e))
* refactor PKCE FlowState to reduce duplicate code
([#1446](#1446))
([b8d0337](b8d0337))


### Bug Fixes

* add http support for https hooks on localhost
([#1484](#1484))
([5c04104](5c04104))
* cleanup panics due to bad inactivity timeout code
([#1471](#1471))
([548edf8](548edf8))
* **docs:** remove bracket on file name for broken link
([#1493](#1493))
([96f7a68](96f7a68))
* impose expiry on auth code instead of magic link
([#1440](#1440))
([35aeaf1](35aeaf1))
* invalidate email, phone OTPs on password change
([#1489](#1489))
([960a4f9](960a4f9))
* move creation of flow state into function
([#1470](#1470))
([4392a08](4392a08))
* prevent user email side-channel leak on verify
([#1472](#1472))
([311cde8](311cde8))
* refactor email sending functions
([#1495](#1495))
([285c290](285c290))
* refactor factor_test to centralize setup
([#1473](#1473))
([c86007e](c86007e))
* refactor mfa challenge and tests
([#1469](#1469))
([6c76f21](6c76f21))
* Resend SMS when duplicate SMS sign ups are made
([#1490](#1490))
([73240a0](73240a0))
* unlink identity bugs
([#1475](#1475))
([73e8d87](73e8d87))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants