fix: use signing jwk to sign oauth state #1728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 10476966113Details
💛 - Coveralls |
hf
reviewed
Aug 21, 2024
hf
approved these changes
Aug 21, 2024
kangmingtay
pushed a commit
that referenced
this pull request
Aug 21, 2024
🤖 I have created a release *beep* *boop* --- ## [2.159.0](v2.158.1...v2.159.0) (2024-08-21) ### Features * Vercel marketplace OIDC ([#1731](#1731)) ([a9ff361](a9ff361)) ### Bug Fixes * add error codes to password login flow ([#1721](#1721)) ([4351226](4351226)) * change phone constraint to per user ([#1713](#1713)) ([b9bc769](b9bc769)) * custom SMS does not work with Twilio Verify ([#1733](#1733)) ([dc2391d](dc2391d)) * ignore errors if transaction has closed already ([#1726](#1726)) ([53c11d1](53c11d1)) * redirect invalid state errors to site url ([#1722](#1722)) ([b2b1123](b2b1123)) * remove TOTP field for phone enroll response ([#1717](#1717)) ([4b04327](4b04327)) * use signing jwk to sign oauth state ([#1728](#1728)) ([66fd0c8](66fd0c8)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
What is the current behavior?
GOTRUE_JWT_SECRETto be set (other than it being a fallback option) just for the sake of signing the oauth stateWhat is the new behavior?
Feel free to include screenshots if it includes visual changes.
Additional context
Add any other context or screenshots.