Fix: revert provider type to maintain backward compatibility #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dshukertjr apologies for the change again, when this PR is merged it will probably break the gotrue dart client library. We decided to revert the breaking change because it was problematic for our users on the gotrue js client library. Going forward, we'll bump the major version on any breaking changes introduced and deprecate the old field properly. |
awalias
reviewed
Oct 19, 2021
awalias
approved these changes
Oct 19, 2021
|
🎉 This PR is included in version 2.1.12 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
Thanks for the heads up @kangmingtay! We haven't made any changes to the Dart library as we were waiting for the official announcement of breaking change being introduced, so everything is cool! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
providerfield toapp_metadatato maintain backward compatibility across client librariesprovidersfield to store the list of providers used to sign-in for a user