Generate Recovery Codes #501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ase/gotrue into j0_generate_recovery_codes
J0
commented
Jun 30, 2022
J0
commented
Jun 30, 2022
J0
commented
Jun 30, 2022
kangmingtay
approved these changes
Jun 30, 2022
| @@ -13,8 +13,12 @@ import ( | |||
| ) | |||
|
|
|||
| // SecureToken creates a new random token | |||
| func SecureToken() string { | |||
| b := make([]byte, 16) | |||
| func SecureToken(options ...int) string { | |||
There was a problem hiding this comment.
why do we take in a variable argument list here?
There was a problem hiding this comment.
Oh this is a way of taking in optional arguments. SecureToken() is used to generate recovery codes which are of length 8 instead of the default of length 16, passing in an int (e.g. SecureToken(8)) will return a length 8 random string
|
Going to merge first to aid development of other branches, have addressed the comments but feel free to let me know if there are additional changes we should make -- will file a PR against the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
This PR should add the ability for a user signed in with a single factor(or more factors) to call
/mfa/%s/generate_recovery_codesto produce recovery codes which will eventually be used toSignIn, recover a factor.Given the all encompassing nature of this endpoint it should eventually move out of the
/mfaroute.There should also be a rate limiter on this but haven't decided on value.
What is the current behavior?
None
What is the new behavior?
Feel free to include screenshots if it includes visual changes.